From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 10/10] gnu: Add python-barbicanclient.
Date: Sat, 30 Apr 2016 17:33:54 -0400
Message-ID: <20160430213354.GB32628@jasmine>
References: <1461939663-5936-1-git-send-email-tipecaml@gmail.com>
	<1461939663-5936-11-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53416)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1awcWp-0008Ex-L7
	for guix-devel@gnu.org; Sat, 30 Apr 2016 17:34:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1awcWe-0003H5-2a
	for guix-devel@gnu.org; Sat, 30 Apr 2016 17:34:14 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40197)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1awcWb-00039E-RT
	for guix-devel@gnu.org; Sat, 30 Apr 2016 17:34:08 -0400
Content-Disposition: inline
In-Reply-To: <1461939663-5936-11-git-send-email-tipecaml@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

On Fri, Apr 29, 2016 at 04:21:03PM +0200, Cyril Roelandt wrote:
> * gnu/packages/openstack.scm (python-barbicanclient, python2-barbicanclient):
> New variables.
> * gnu/packages/patches/python-barbicanclient-assertItemsEqual.patch: New file.
> * gnu/local.ml: Add it here.

Can you use "* gnu/local.mk (dist_patch_DATA)"?

> +        (patches (search-patches
> +                  ;; testtools.TestCase.assertItemsEqual does not exist in our
> +                  ;; version of testtools. Remove this patch once we update
> +                  ;;testtools.

Can you copy this comment into the patch itself?

> +    (native-inputs
> +      ;; Tests
> +      `(("python-setuptools" ,python-setuptools)

I think you could move the comment to this space. Also, is setuptools
needed for the python-3 version?