[PATCH] Add more symlinks to python-wrapper

[PATCH] Add more symlinks to python-wrapper

[Hartmut Goebel]

Enclosed patch adds missing sysmlinks "python-config" and "pip" to
python-wrapper.

I did not add a symlink for easy_install, this this is obsoleted by pip.

Hartmut Goebel (1):
  gnu: wrap-python3: create more symlinks.

 gnu/packages/python.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.7.4

[PATCH] gnu: wrap-python3: create more symlinks.

[Hartmut Goebel]

* gnu/pyckages/python.csm (wrap-python3): Create symlinks for
  pip and python-config, too.
---
 gnu/packages/python.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 65210e0..5c4bf3b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
 ;;; Copyright © 2015, 2016 Chris Marusich <cmmarusich@gmail.com>
 ;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org>
+;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -334,8 +335,8 @@ data types.")
                   (lambda (old new)
                     (symlink (string-append python old)
                              (string-append bin "/" new)))
-                  `("python3" ,"pydoc3" ,"idle3")
-                  `("python"  ,"pydoc"  ,"idle"))))))
+                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
+                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))
     (synopsis "Wrapper for the Python 3 commands")
     (description
      "This package provides wrappers for the commands of Python@tie{}3.x such
-- 
2.7.4

Re: [PATCH] gnu: wrap-python3: create more symlinks.

[Leo Famulari]

On Thu, Apr 21, 2016 at 10:23:19PM +0200, Hartmut Goebel wrote:
> * gnu/pyckages/python.csm (wrap-python3): Create symlinks for
>   pip and python-config, too.

[...]

> +++ b/gnu/packages/python.scm
> -                  `("python3" ,"pydoc3" ,"idle3")
> -                  `("python"  ,"pydoc"  ,"idle"))))))
> +                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
> +                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))

Do any Pythonista's have any comments on this proposal?

Re: [PATCH] gnu: wrap-python3: create more symlinks.

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> On Thu, Apr 21, 2016 at 10:23:19PM +0200, Hartmut Goebel wrote:
>> * gnu/pyckages/python.csm (wrap-python3): Create symlinks for
>>   pip and python-config, too.
>
> [...]
>
>> +++ b/gnu/packages/python.scm
>> -                  `("python3" ,"pydoc3" ,"idle3")
>> -                  `("python"  ,"pydoc"  ,"idle"))))))
>> +                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
>> +                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))
>
> Do any Pythonista's have any comments on this proposal?

I’m not much of a Pythonista, but this look good to me.
Could you push to core-updates?

Thanks!

Ludo’.

Re: [PATCH] gnu: wrap-python3: create more symlinks.

[Alex Kost]

Ludovic Courtès (2016-05-05 17:58 +0300) wrote:

> Leo Famulari <leo@famulari.name> skribis:
>
>> On Thu, Apr 21, 2016 at 10:23:19PM +0200, Hartmut Goebel wrote:
>>> * gnu/pyckages/python.csm (wrap-python3): Create symlinks for
>>>   pip and python-config, too.
>>
>> [...]
>>
>>> +++ b/gnu/packages/python.scm
>>> -                  `("python3" ,"pydoc3" ,"idle3")
>>> -                  `("python"  ,"pydoc"  ,"idle"))))))
>>> +                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
>>> +                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))
>>
>> Do any Pythonista's have any comments on this proposal?
>
> I’m not much of a Pythonista, but this look good to me.
> Could you push to core-updates?

I was going to say that these lists of strings are strangely quoted, but
then I saw that Mark fixed it in the core-updates¹, so this patch should
be adjusted accordingly.

¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=5c19dab94591db68c5361bc2521321fc587dc704

-- 
Alex

Re: [PATCH] gnu: wrap-python3: create more symlinks.

[Leo Famulari]

On Thu, May 05, 2016 at 07:41:02PM +0300, Alex Kost wrote:
> Ludovic Courtès (2016-05-05 17:58 +0300) wrote:
> 
> > Leo Famulari <leo@famulari.name> skribis:
> >
> >> On Thu, Apr 21, 2016 at 10:23:19PM +0200, Hartmut Goebel wrote:
> >>> * gnu/pyckages/python.csm (wrap-python3): Create symlinks for
> >>>   pip and python-config, too.
> >>
> >> [...]
> >>
> >>> +++ b/gnu/packages/python.scm
> >>> -                  `("python3" ,"pydoc3" ,"idle3")
> >>> -                  `("python"  ,"pydoc"  ,"idle"))))))
> >>> +                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
> >>> +                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))
> >>
> >> Do any Pythonista's have any comments on this proposal?
> >
> > I’m not much of a Pythonista, but this look good to me.
> > Could you push to core-updates?
> 
> I was going to say that these lists of strings are strangely quoted, but
> then I saw that Mark fixed it in the core-updates¹, so this patch should
> be adjusted accordingly.

Committed to core-updates with the requested changes as 478e75b53b.

> 
> ¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=5c19dab94591db68c5361bc2521321fc587dc704
> 
> -- 
> Alex

[PATCH] gnu: wrap-python3: create more symlinks.

[Hartmut Goebel]

* gnu/pyckages/python.csm (wrap-python3): Create symlinks for
  pip and python-config, too.
---
 gnu/packages/python.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 65210e0..5c4bf3b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
 ;;; Copyright © 2015, 2016 Chris Marusich <cmmarusich@gmail.com>
 ;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org>
+;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -334,8 +335,8 @@ data types.")
                   (lambda (old new)
                     (symlink (string-append python old)
                              (string-append bin "/" new)))
-                  `("python3" ,"pydoc3" ,"idle3")
-                  `("python"  ,"pydoc"  ,"idle"))))))
+                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
+                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))
     (synopsis "Wrapper for the Python 3 commands")
     (description
      "This package provides wrappers for the commands of Python@tie{}3.x such
-- 
2.7.4

Re: [PATCH] gnu: wrap-python3: create more symlinks.

[Hartmut Goebel]

[-- Attachment #1.1: Type: text/plain, Size: 469 bytes --]

Sorry, this patch was accidentaly resend.

-- 
Schönen Gruß
Hartmut Goebel
Dipl.-Informatiker (univ), CISSP, CSSLP, ISO 27001 Lead Implementer
Information Security Management, Security Governance, Secure Software
Development

Goebel Consult, Landshut
http://www.goebel-consult.de

Blog:
http://www.goebel-consult.de/blog/liberario-als-alternative-zum-db-navigator-und-zu-offi

Kolumne: http://www.cissp-gefluester.de/2010-01-hinterturen-allen-ortes


[-- Attachment #1.2: Type: text/html, Size: 1425 bytes --]

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 2430 bytes --]

Re: [PATCH] gnu: wrap-python3: create more symlinks.

[Andreas Enge]

Hi Hartmut,

the content of the patch looks good, but I cannot apply it with "git am";
is it relative to an older git commit? I could correct it myself, but
then you would disappear as an author.

Andreas

Re: [PATCH] gnu: wrap-python3: create more symlinks.

[Hartmut Goebel]

Hello Andreas,

Am 15.06.2016 um 16:27 schrieb Andreas Enge:
> the content of the patch looks good, but I cannot apply it with "git am";
> is it relative to an older git commit? I could correct it myself, but
> then you would disappear as an author.

I've jsut send an updated version of the patch. I'd appreciate if you
could take care of it.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: [PATCH] gnu: wrap-python3: create more symlinks.

[Andreas Enge]

Hello Hartmut,

On Fri, Jun 17, 2016 at 09:45:22PM +0200, Hartmut Goebel wrote:
> I've jsut send an updated version of the patch. I'd appreciate if you
> could take care of it.

thanks a lot! I applied it locally and was about to push it to master,
when I started to wonder:
$ ./pre-inst-env guix refresh -l python-wrapper
Building the following 558 packages would ensure 1569 dependent packages are rebuilt

This is maybe too much right now; question to those who suffer the most from
core-updates: Should I push it to core-updates-next? This patch is nice to
have, but probably not very urgent.

Andreas

Re: [PATCH] gnu: wrap-python3: create more symlinks.

[Andreas Enge]

On Mon, Jun 20, 2016 at 11:10:20AM +0200, Andreas Enge wrote:
> This is maybe too much right now; question to those who suffer the most from
> core-updates: Should I push it to core-updates-next? This patch is nice to
> have, but probably not very urgent.

I just pushed to core-updates-next.

Andreas