From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH] guix: use '@' in package-full-name instead of '-'
Date: Wed, 27 Apr 2016 22:03:16 -0500
Message-ID: <20160427220316.1d009150@openmailbox.org>
References: <1461810323-21018-1-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47206)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1avcEl-0000fH-V5
	for guix-devel@gnu.org; Wed, 27 Apr 2016 23:03:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1avcEi-0002jc-P7
	for guix-devel@gnu.org; Wed, 27 Apr 2016 23:03:31 -0400
Received: from smtp22.openmailbox.org ([62.4.1.56]:58327)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1avcEi-0002j8-GH
	for guix-devel@gnu.org; Wed, 27 Apr 2016 23:03:28 -0400
In-Reply-To: <1461810323-21018-1-git-send-email-tipecaml@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

On Thu, 28 Apr 2016 04:25:23 +0200
Cyril Roelandt <tipecaml@gmail.com> wrote:

> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
> ---
>  guix/packages.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/guix/packages.scm b/guix/packages.scm
> index d62d1f3..e33791e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -346,7 +346,7 @@ name of its URI."
>  
>  (define (package-full-name package)
>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."

Could you replace the '-' here too? --------------^

> -  (string-append (package-name package) "-" (package-version package)))
> +  (string-append (package-name package) "@" (package-version package)))
>  
>  (define (%standard-patch-inputs)
>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))

LGTM!

`~Eric