From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/2] gnu: Add python-pyqi.
Date: Mon, 25 Apr 2016 14:11:10 -0400
Message-ID: <20160425181110.GB8957@jasmine>
References: <1461500860-8272-1-git-send-email-donttrustben@gmail.com>
	<1461500860-8272-2-git-send-email-donttrustben@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51280)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aukyZ-0001xm-Mm
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:11:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aukyW-0004sr-Gu
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:11:15 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50376)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aukyW-0004sn-Ag
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:11:12 -0400
Content-Disposition: inline
In-Reply-To: <1461500860-8272-2-git-send-email-donttrustben@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: Guix-devel@gnu.org

On Sun, Apr 24, 2016 at 10:27:39PM +1000, Ben Woodcroft wrote:
> * gnu/packages/python.scm (python-pyqi, python2-pyqi): New variables.

Thanks for the patches!

> +    (source
> +     (origin
> +       (method url-fetch)
> +       ;; Use GitHub as source because PyPI archive does not contain tests.
> +       (uri (string-append "https://github.com/biocore/pyqi/archive/"
> +                           version ".tar.gz"))

I've had some success asking upstream authors to start releasing their
test suites on PyPi. YMMV. This is not a "blocker".

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'remove-version-requirement
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* "setup.py"
> +               (("if ver not in \\['2.7', '3.3'\\]:")
> +                (string-append
> +                 "if ver not in ['2.7', '3.3', '"
> +                 (string-take (string-take-right
> +                               (assoc-ref inputs "python") 5) 3)
> +                 "']:")))))

I assume everything works with this change :)

> +    (home-page "http://bipy.github.io/pyqi")

This is what PyPi calls the home page, but I get 404. Did it work for
you, meaning I am experiencing a transient error? Or should we use
something else?