unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: Guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add python-pyqi.
Date: Mon, 25 Apr 2016 14:11:10 -0400	[thread overview]
Message-ID: <20160425181110.GB8957@jasmine> (raw)
In-Reply-To: <1461500860-8272-2-git-send-email-donttrustben@gmail.com>

On Sun, Apr 24, 2016 at 10:27:39PM +1000, Ben Woodcroft wrote:
> * gnu/packages/python.scm (python-pyqi, python2-pyqi): New variables.

Thanks for the patches!

> +    (source
> +     (origin
> +       (method url-fetch)
> +       ;; Use GitHub as source because PyPI archive does not contain tests.
> +       (uri (string-append "https://github.com/biocore/pyqi/archive/"
> +                           version ".tar.gz"))

I've had some success asking upstream authors to start releasing their
test suites on PyPi. YMMV. This is not a "blocker".

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'remove-version-requirement
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* "setup.py"
> +               (("if ver not in \\['2.7', '3.3'\\]:")
> +                (string-append
> +                 "if ver not in ['2.7', '3.3', '"
> +                 (string-take (string-take-right
> +                               (assoc-ref inputs "python") 5) 3)
> +                 "']:")))))

I assume everything works with this change :)

> +    (home-page "http://bipy.github.io/pyqi")

This is what PyPi calls the home page, but I get 404. Did it work for
you, meaning I am experiencing a transient error? Or should we use
something else?

  reply	other threads:[~2016-04-25 18:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-24 12:27 [PATCH 0/2]: Add biom-format Ben Woodcroft
2016-04-24 12:27 ` [PATCH 1/2] gnu: Add python-pyqi Ben Woodcroft
2016-04-25 18:11   ` Leo Famulari [this message]
2016-04-26 14:24     ` Ricardo Wurmus
2016-04-24 12:27 ` [PATCH 2/2] gnu: Add python-biom-format Ben Woodcroft
2016-04-25 18:13   ` Leo Famulari
2016-04-24 12:47 ` [PATCH 0/2]: Add biom-format Ben Woodcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160425181110.GB8957@jasmine \
    --to=leo@famulari.name \
    --cc=Guix-devel@gnu.org \
    --cc=donttrustben@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).