From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/6] gnu: Add python-tblib and python2-tblib
Date: Sun, 24 Apr 2016 15:40:43 -0400
Message-ID: <20160424194043.GA10633@jasmine>
References: <1461266395-2731-1-git-send-email-h.goebel@crazy-compilers.com>
	<1461266395-2731-2-git-send-email-h.goebel@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60942)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1auPtf-0005HW-2j
	for guix-devel@gnu.org; Sun, 24 Apr 2016 15:40:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1auPtb-000096-Sv
	for guix-devel@gnu.org; Sun, 24 Apr 2016 15:40:47 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35791)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1auPtb-000091-MY
	for guix-devel@gnu.org; Sun, 24 Apr 2016 15:40:43 -0400
Content-Disposition: inline
In-Reply-To: <1461266395-2731-2-git-send-email-h.goebel@crazy-compilers.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

On Thu, Apr 21, 2016 at 09:19:48PM +0200, Hartmut Goebel wrote:
> * packages/python.scm (python-tblib) (python2-tblib): New
>   variables.

Thanks for the updated patch!

> +(define-public python-tblib
> +  (package
> +    (name "python-tblib")
> +    (version "1.3.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "tblib" version))
> +       (sha256
> +        (base32
> +         "02iahfkfa927hb4jq2bak36ldihwapzacfiq5lyxg8llwn98a1yi"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +        (replace 'check
> +         ;; Run py.test, excluding some file which are no tests and fail to i
> +         ;; mport.  Excluding know problem-files is less intrusive to what
> +         ;; upstream has configured to be tested than restricting to only scan
> +         ;; directory tests/.
> +         (lambda _
> +           (zero? (system* "py.test" "--ignore=setup.py"
> +                           "--ignore=docs/conf.py"
> +                           "--ignore=ci/appveyor-download.py")))))))

I wonder if this really the best thing to do? With this method, the only
files that appear to be "tested" are the various .rst files, which are
just documentation.

Can you ask upstream how they prefer the tests to be run?