unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/6] gnu: Add python-tblib and python2-tblib
Date: Sun, 24 Apr 2016 15:40:43 -0400	[thread overview]
Message-ID: <20160424194043.GA10633@jasmine> (raw)
In-Reply-To: <1461266395-2731-2-git-send-email-h.goebel@crazy-compilers.com>

On Thu, Apr 21, 2016 at 09:19:48PM +0200, Hartmut Goebel wrote:
> * packages/python.scm (python-tblib) (python2-tblib): New
>   variables.

Thanks for the updated patch!

> +(define-public python-tblib
> +  (package
> +    (name "python-tblib")
> +    (version "1.3.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "tblib" version))
> +       (sha256
> +        (base32
> +         "02iahfkfa927hb4jq2bak36ldihwapzacfiq5lyxg8llwn98a1yi"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +        (replace 'check
> +         ;; Run py.test, excluding some file which are no tests and fail to i
> +         ;; mport.  Excluding know problem-files is less intrusive to what
> +         ;; upstream has configured to be tested than restricting to only scan
> +         ;; directory tests/.
> +         (lambda _
> +           (zero? (system* "py.test" "--ignore=setup.py"
> +                           "--ignore=docs/conf.py"
> +                           "--ignore=ci/appveyor-download.py")))))))

I wonder if this really the best thing to do? With this method, the only
files that appear to be "tested" are the various .rst files, which are
just documentation.

Can you ask upstream how they prefer the tests to be run?

  reply	other threads:[~2016-04-24 19:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-21 19:19 [PATCH 0/6] Updated: Some new python packages Hartmut Goebel
2016-04-21 19:19 ` [PATCH 1/6] gnu: Add python-tblib and python2-tblib Hartmut Goebel
2016-04-24 19:40   ` Leo Famulari [this message]
2016-04-21 19:19 ` [PATCH 2/6] gnu: add python-sqlparse and python2-sqlparse Hartmut Goebel
2016-04-24 19:24   ` Branching based on Python version (was [PATCH 2/6] gnu: add python-sqlparse and python2-sqlparse) Leo Famulari
2016-04-24 21:40     ` Ludovic Courtès
2016-04-25 19:06       ` Leo Famulari
2016-05-29 16:21       ` Hartmut Goebel
2016-04-21 19:19 ` [PATCH 3/6] gnu: add python-selenium and python2-selenium Hartmut Goebel
2016-04-24 19:19   ` Leo Famulari
2016-04-24 21:36   ` Ludovic Courtès
2016-04-21 19:19 ` [PATCH 4/6] gnu: Add python2-ipaddr, a Python-2-only package Hartmut Goebel
2016-04-21 19:19 ` [PATCH 5/6] gnu: add python-maxminddb and python2-maxminddb Hartmut Goebel
2016-04-21 19:19 ` [PATCH 6/7] gnu: add comment pointing to python-requests-mock in openstack Hartmut Goebel
2016-04-21 19:19 ` [PATCH 6/6] gnu: add python-geoip2 and python2-geoip2 Hartmut Goebel
2016-04-21 20:29   ` Hartmut Goebel
2016-04-21 19:19 ` [PATCH 7/7] " Hartmut Goebel
2016-04-21 20:30   ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160424194043.GA10633@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).