[PATCH] Add python-tables.

[PATCH] Add python-tables.

[Ricardo Wurmus]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-python-tables.patch --]
[-- Type: text/x-patch, Size: 2700 bytes --]

From d602df616b797de2777a1ffdf0dc48a1ca6edca5 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Thu, 21 Apr 2016 17:27:42 +0200
Subject: [PATCH] gnu: Add python-tables.

* gnu/packages/python.scm (python-tables, python2-tables): New
  variables.
---
 gnu/packages/python.scm | 50 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 3c8c3d7..bbab29e 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5851,6 +5851,56 @@ printing of sub-tables by specifying a row range.")
 (define-public python2-prettytable
   (package-with-python2 python-prettytable))
 
+(define-public python-tables
+  (package
+    (name "python-tables")
+    (version "3.2.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "tables" version))
+       (sha256
+        (base32
+         "117s6w7s3yxafpmf3zz3svana7xfrsviw01va1xp7h8ylx8v6r1m"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:configure-flags
+       (list (string-append "--hdf5="
+                            (assoc-ref %build-inputs "hdf5")))
+       ;; FIXME: python-build-system does not pass configure-flags to "build"
+       ;; or "check", so we must override the build and check phases.
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'build
+           (lambda* (#:key inputs #:allow-other-keys)
+             (zero? (system* "python" "setup.py" "build"
+                             (string-append "--hdf5="
+                                            (assoc-ref inputs "hdf5"))))))
+         (replace 'check
+           (lambda* (#:key inputs #:allow-other-keys)
+             (zero? (system* "python" "setup.py" "check"
+                             (string-append "--hdf5="
+                                            (assoc-ref inputs "hdf5")))))))))
+    (propagated-inputs
+     `(("python-numexpr" ,python-numexpr)
+       ("python-numpy" ,python-numpy)))
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)
+       ("python-cython" ,python-cython)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("hdf5" ,hdf5)
+       ("bzip2" ,bzip2)
+       ("zlib" ,zlib)))
+    (home-page "http://www.pytables.org/")
+    (synopsis "Hierarchical datasets for Python")
+    (description "PyTables is a package for managing hierarchical datasets and
+designed to efficently cope with extremely large amounts of data.")
+    (license bsd-3)))
+
+(define-public python2-tables
+  (package-with-python2 python-tables))
+
 (define-public python-pyasn1
   (package
     (name "python-pyasn1")
-- 
2.7.3

Re: [PATCH] Add python-tables.

[Leo Famulari]

On Thu, Apr 21, 2016 at 05:28:58PM +0200, Ricardo Wurmus wrote:
> Subject: [PATCH] gnu: Add python-tables.
  
> +    (arguments
> +     `(#:configure-flags
> +       (list (string-append "--hdf5="
> +                            (assoc-ref %build-inputs "hdf5")))
> +       ;; FIXME: python-build-system does not pass configure-flags to "build"
> +       ;; or "check", so we must override the build and check phases.

Does setting #:configure-flags have any effect at all?

Otherwise, looks okay!

Re: [PATCH] Add python-tables.

[Ricardo Wurmus]

Leo Famulari <leo@famulari.name> writes:

> On Thu, Apr 21, 2016 at 05:28:58PM +0200, Ricardo Wurmus wrote:
>> Subject: [PATCH] gnu: Add python-tables.
>   
>> +    (arguments
>> +     `(#:configure-flags
>> +       (list (string-append "--hdf5="
>> +                            (assoc-ref %build-inputs "hdf5")))
>> +       ;; FIXME: python-build-system does not pass configure-flags to "build"
>> +       ;; or "check", so we must override the build and check phases.
>
> Does setting #:configure-flags have any effect at all?

No, unfortunately, it does not.  I think we should improve the
python-build-system here.

Thanks for the review!  I’ll push it after removing the configure-flags
and addressing Ben’s question.

~~ Ricardo