Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 3642 bytes --]

On Sun, Apr 24, 2016 at 11:06:17PM +1000, Ben Woodcroft wrote:
> * gnu/packages/python.scm (python-pytest-pep8, python2-pytest-pep8): New
> variables.
> ---
>  gnu/packages/python.scm | 60 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index c07dae6..b1a4969 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -8714,6 +8714,66 @@ development version of CPython that are not available in older releases.")
>        (native-inputs
>         `(("python2-setuptools" ,python2-setuptools))))))
>  
> +(define-public python-pytest-pep8
> +  (package
> +    (name "python-pytest-pep8")
> +    (version "1.0.6")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "pytest-pep8" version))
> +       (sha256
> +        (base32
> +         "06032agzhw1i9d9qlhfblnl3dw5hcyxhagn7b120zhrszbjzfbh3"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'remove-failing-test
> +           ;; Ignore the known test failure.
> +           ;; https://bitbucket.org/pytest-dev/pytest-pep8/issues/8/test-failure
> +           (lambda _
> +             (substitute* "test_pep8.py"
> +               (("^def test_ok_verbose") "def dont_run"))
> +             #t))
> +         (add-after 'install 'post-install-check
> +           ;; 'setup.py test' does not run tests
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (setenv "PYTHONPATH"
> +                       (string-append
> +                        (getenv "PYTHONPATH")
> +                        ":"
> +                        out
> +                        "/lib/python"

some of the previous lines should be combined into one line

> +                        (string-take (string-take-right
> +                                      (assoc-ref inputs "python") 5) 3)
> +                        "/site-packages"))
> +               (zero?
> +                (system*
> +                 (string-append out "/bin/py.test") "test_pep8.py"))))))))
> +    (propagated-inputs
> +     `(("python-pytest-cache", python-pytest-cache)
> +       ("python-pytest" ,python-pytest)
> +       ("python-pep8" ,python-pep8)))

Are you sure all of these need to be propagated?

> +    (home-page "https://bitbucket.org/pytest-dev/pytest-pep8")
> +    (synopsis "Pytest plugin to check PEP8 requirements")
> +    (description
> +     "Pytest-pep8 is a py.test plugin for efficiently checking compliance to
> +the PEP8 style guide.  If you type @code{py.test --pep8} every file ending in
> +@code{.py} will be discovered and PEP8-checked, starting from the command line
> +arguments.")
> +    (license license:expat)
> +    (properties `((python2-variant . ,(delay python2-pytest-pep8))))))
> +
> +(define-public python2-pytest-pep8
> +  (let ((base (package-with-python2
> +               (strip-python2-variant python-pytest-pep8))))
> +    (package
> +      (inherit base)
> +      (native-inputs
> +       `(("python2-setuptools" ,python2-setuptools))))))
> +
>  (define-public python-cysignals
>    (package
>      (name "python-cysignals")
> -- 
> 2.5.0
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]