From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] IPython: Use 'python2-variant'.
Date: Tue, 19 Apr 2016 21:16:54 -0400
Message-ID: <20160420011654.GA17827@jasmine>
References: <5712DEAB.8000001@uq.edu.au> <20160418190710.GC27770@jasmine>
	<5715F72D.4050800@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1asgko-0001Mj-N8
	for guix-devel@gnu.org; Tue, 19 Apr 2016 21:16:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1asgkl-0006Zr-HQ
	for guix-devel@gnu.org; Tue, 19 Apr 2016 21:16:30 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41555)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1asgkl-0006Zm-Dd
	for guix-devel@gnu.org; Tue, 19 Apr 2016 21:16:27 -0400
Content-Disposition: inline
In-Reply-To: <5715F72D.4050800@uq.edu.au>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

On Tue, Apr 19, 2016 at 07:15:25PM +1000, Ben Woodcroft wrote:
> On 19/04/16 05:07, Leo Famulari wrote:
> >>  (define-public python2-ipython
> >>-  (let ((ipython (package-with-python2 python-ipython)))
> >>+  (let ((parent (package-with-python2
> >>+                 (strip-python2-variant python-ipython))))
> >I prefer to the upstream name (ipython) rather than "parent". Some
> >people use "base". I'd rather not introduce a 3rd option ;)
> 
> Fair point. I'd prefer "base" since then copy and paste works better, which
> is especially useful if the addition of setuptools as a native input is the
> only difference.

Good point! I hadn't thought of that benefit of using 'base'.