From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/7] gnu: Add python-tblib and python2-tblib
Date: Mon, 18 Apr 2016 16:19:08 -0400
Message-ID: <20160418201908.GD26231@jasmine>
References: <1460926257-25147-1-git-send-email-h.goebel@crazy-compilers.com>
	<1460926257-25147-2-git-send-email-h.goebel@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1asFd7-0000lj-9Q
	for guix-devel@gnu.org; Mon, 18 Apr 2016 16:18:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1asFd4-00036d-0T
	for guix-devel@gnu.org; Mon, 18 Apr 2016 16:18:45 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:51370)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1asFd3-00036O-TU
	for guix-devel@gnu.org; Mon, 18 Apr 2016 16:18:41 -0400
Content-Disposition: inline
In-Reply-To: <1460926257-25147-2-git-send-email-h.goebel@crazy-compilers.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

On Sun, Apr 17, 2016 at 10:50:51PM +0200, Hartmut Goebel wrote:
> * packages/python.scm (python-tblib) (python2-tblib): New
>   functions.

[...]

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +        (replace 'check
> +         (lambda _
> +           (zero? (system* "py.test" "--ignore=setup.py"
> +                           "--ignore=docs/conf.py"
> +                           "--ignore=ci/appveyor-download.py")))))))

Can you add a comment explaining why we have to replace the check phase
and what these options are doing?

[...]

> +    (description
> +     "Traceback serialization allows you to:
> +
> +* Pickle tracebacks and raise exceptions with pickled tracebacks in different
> +  processes.  This allows better error handling when running code over
> +  multiple processes (imagine multiprocessing, billiard, futures, celery etc).
> +
> +* Parse traceback strings and raise with the parsed tracebacks.")

Please see the package definition of python-debian for an example of how
to make these sorts of lists in texinfo (which is what the description
is).