unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 7/7] gnu: add python-geoip2 and python2-geoip2
Date: Mon, 18 Apr 2016 16:17:31 -0400	[thread overview]
Message-ID: <20160418201731.GC26231@jasmine> (raw)
In-Reply-To: <1460926257-25147-8-git-send-email-h.goebel@crazy-compilers.com>

On Sun, Apr 17, 2016 at 10:50:57PM +0200, Hartmut Goebel wrote:
> * gnu/packages/python.scm (python-geoip2) (pythons-geoip2):
>   New functions.

[...]

> +    (arguments `(#:tests? #f)) ; tests require a copy of the database

The maxminddb database?

> +    (inputs
> +     `(("python-maxminddb" ,python-maxminddb) ; >=1.1.0
> +       ("python-requests" ,python-requests) ; >=2.4
> +       ("python-setuptools" ,python-setuptools)))

If setuptools is necessary, it should typically be a native-input, since
it is typically only used at build-time; there are a few exceptions. Is
that not the case for geoip2?

> +    (synopsis "MaxMind GeoIP2 API")
> +    (description "Provides an API for the GeoIP2 web services and databases.
> +The API also works with MaxMind’s free GeoLite2 databases.")

Again, can you give a little more context for the reader?

  reply	other threads:[~2016-04-18 20:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-17 20:50 [PATCH 0/7] Some new python packages Hartmut Goebel
2016-04-17 20:50 ` [PATCH 1/7] gnu: Add python-tblib and python2-tblib Hartmut Goebel
2016-04-18 20:19   ` Leo Famulari
2016-04-17 20:50 ` [PATCH 2/7] gnu: add python-sqlparse and python2-sqlparse Hartmut Goebel
2016-04-18 20:23   ` Leo Famulari
2016-04-18 21:10     ` Hartmut Goebel
2016-04-17 20:50 ` [PATCH 3/7] gnu: add python-selenium and python2-selenium Hartmut Goebel
2016-04-18 20:12   ` Leo Famulari
2016-04-17 20:50 ` [PATCH 4/7] gnu: Add python2-ipaddr, a Python-2-only package Hartmut Goebel
2016-04-18 20:20   ` Leo Famulari
2016-04-18 21:09     ` Hartmut Goebel
2016-04-19  8:41       ` Alex Kost
2016-04-20 17:01         ` Ludovic Courtès
2016-04-17 20:50 ` [PATCH 5/7] gnu: add python-maxminddb and python2-maxminddb Hartmut Goebel
2016-04-18 20:14   ` Leo Famulari
2016-04-18 21:02     ` Hartmut Goebel
2016-04-17 20:50 ` [PATCH 6/7] gnu: add comment pointing to python-requests-mock in openstack Hartmut Goebel
2016-04-18 20:21   ` Leo Famulari
2016-04-18 21:16     ` Leo Famulari
2016-04-19  8:43     ` Alex Kost
2016-04-17 20:50 ` [PATCH 7/7] gnu: add python-geoip2 and python2-geoip2 Hartmut Goebel
2016-04-18 20:17   ` Leo Famulari [this message]
2016-04-18 20:08 ` [PATCH 0/7] Some new python packages Leo Famulari
2016-04-18 20:49   ` Hartmut Goebel
  -- strict thread matches above, loose matches on Subject: below --
2016-04-21 19:19 [PATCH 0/6] Updated: " Hartmut Goebel
2016-04-21 19:19 ` [PATCH 7/7] gnu: add python-geoip2 and python2-geoip2 Hartmut Goebel
2016-04-21 20:30   ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160418201731.GC26231@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).