unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: rennes@openmailbox.org
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/6] gnu: gnome-documents
Date: Mon, 18 Apr 2016 14:44:57 -0400	[thread overview]
Message-ID: <20160418184457.GA27770@jasmine> (raw)
In-Reply-To: <c357a8d5316822d54a2185c68249f680@openmailbox.org>

On Thu, Apr 14, 2016 at 10:35:00AM -0500, rennes@openmailbox.org wrote:
> On 2016-03-29 14:25, ludo@gnu.org wrote:
> >rennes@openmailbox.org skribis:
> >
> >>+     `(#:configure-flags
> >>+       '("--with-ca-certificates=/etc/ssl/certs/ca-certificates.crt")
> >
> >AFAICS glib-networking uses GnuTLS, for which we already had such a
> >setting (except that it can read all the .crt files from /etc/ssl/certs,
> >not just one bundle.)
> 
> I did more tests and remove this part.
> 
> >>+       (modify-phases %standard-phases
> >>+         (add-before 'check 'use-empty-ssl-cert-file
> >>+                     (lambda _
> >>+                       ; Search for ca-certificates.crt files
> >>+                       ; during the check phase.
> >>+                       (setenv "SSL_CERT_FILE" "/dev/null")
> >
> >Does this really have an effect?  This is the environment variable used
> >by OpenSSL, but not GnuTLS.
> 
> indeed, it works.
> 
> Question, to which package module I can add the patch?

I've moved it into web.scm, in the attached revision on your patch. I
can apply it if you think it looks good. What do you think?

I also reorganized the native-inputs a little bit, to put all the
"check" dependencies together.

By the way, thanks for working on this patch series, and SORRY for the
slow review!

  reply	other threads:[~2016-04-18 18:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29  4:04 [PATCH 4/6] gnu: gnome-documents rennes
2016-03-29 20:25 ` Ludovic Courtès
2016-04-14 15:35   ` rennes
2016-04-18 18:44     ` Leo Famulari [this message]
2016-04-20 13:26       ` rennes
2016-04-30  2:03         ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160418184457.GA27770@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=rennes@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).