[PATCH] gnu: Add wmclock.

[PATCH] gnu: Add wmclock.

[Kei Yamashita]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

This patch also sources Debian for the lastest source tarball. Because
this software makes many languages available through configure
script switches, I was wondered if they should be enabled by default or
not.

[-- Attachment #2: 0001-gnu-Add-wmclock.patch --]
[-- Type: application/octet-stream, Size: 1920 bytes --]

From 15c0f48c3b9c510228a95655e11f95dbca5fbf91 Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Thu, 7 Apr 2016 12:53:43 -0400
Subject: [PATCH] gnu: Add wmclock.

* gnu/packages/gnustep.scm (wmclock): New variable.
---
 gnu/packages/gnustep.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/gnustep.scm b/gnu/packages/gnustep.scm
index 8c43085..4977507 100644
--- a/gnu/packages/gnustep.scm
+++ b/gnu/packages/gnustep.scm
@@ -181,3 +181,37 @@ on and off by clicking the mouse button over the application.  If the CPU usage
 hits a certain threshold, an alarm-mode will alert you by turning back-light
 on.")
     (license gpl2+)))
+
+(define-public wmclock
+  (package
+    (name "wmclock")
+    (version "1.0.16")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://debian/pool/main/w/wmclock/"
+                    name "_" version ".orig.tar.gz"))
+              (sha256
+               (base32
+                "1lx276ba8r2yydhmwj1g586jdqg695ad89ng36fr3mb067gvb2rz"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'autoconf
+           (lambda _ (zero? (system* "autoreconf" "-vfi")))))))
+    (inputs
+     `(("libx11" ,libx11)
+       ("libxext" ,libxext)
+       ("libxpm" ,libxpm)))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("pkg-config" ,pkg-config)))
+    (home-page "http://www.bluestop.org/wmclock/")
+    (synopsis "Display the date and time")
+    (description
+     "wmclock is an applet for Window Maker which displays the date and time in
+a dockable tile.  It features multiple language support, 24h or 12h time
+display, and can run a user-specified program on mouse click.")
+    (license gpl2+)))
-- 
2.7.3

Re: [PATCH] gnu: Add wmclock.

[Mathieu Lirzin]

Hello,

Kei Yamashita <kei@openmailbox.org> writes:

> From 15c0f48c3b9c510228a95655e11f95dbca5fbf91 Mon Sep 17 00:00:00 2001
> From: Kei Yamashita <kei@openmailbox.org>
> Date: Thu, 7 Apr 2016 12:53:43 -0400
> Subject: [PATCH] gnu: Add wmclock.
>
> * gnu/packages/gnustep.scm (wmclock): New variable.
> ---

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'autoconf
> +           (lambda _ (zero? (system* "autoreconf" "-vfi")))))))

Does the tarball contains a configure script?  If not or if it is not
possible to use it, please provide a commentary to explain why
maintainer tools are required since this is not a expected behavior.

Thanks,

-- 
Mathieu Lirzin

Re: [PATCH] gnu: Add wmclock.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2694 bytes --]

On Thu, 7 Apr 2016 12:57:15 -0400
Kei Yamashita <kei@openmailbox.org> wrote:

> From 15c0f48c3b9c510228a95655e11f95dbca5fbf91 Mon Sep 17 00:00:00 2001
> From: Kei Yamashita <kei@openmailbox.org>
> Date: Thu, 7 Apr 2016 12:53:43 -0400
> Subject: [PATCH] gnu: Add wmclock.
> 
> * gnu/packages/gnustep.scm (wmclock): New variable.
> ---
>  gnu/packages/gnustep.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/gnu/packages/gnustep.scm b/gnu/packages/gnustep.scm
> index 8c43085..4977507 100644
> --- a/gnu/packages/gnustep.scm
> +++ b/gnu/packages/gnustep.scm
> @@ -181,3 +181,37 @@ on and off by clicking the mouse button over the application.  If the CPU usage
>  hits a certain threshold, an alarm-mode will alert you by turning back-light
>  on.")
>      (license gpl2+)))
> +
> +(define-public wmclock
> +  (package
> +    (name "wmclock")
> +    (version "1.0.16")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://debian/pool/main/w/wmclock/"
> +                    name "_" version ".orig.tar.gz"))
> +              (sha256
> +               (base32
> +                "1lx276ba8r2yydhmwj1g586jdqg695ad89ng36fr3mb067gvb2rz"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'autoconf
> +           (lambda _ (zero? (system* "autoreconf" "-vfi")))))))
> +    (inputs
> +     `(("libx11" ,libx11)
> +       ("libxext" ,libxext)
> +       ("libxpm" ,libxpm)))
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("pkg-config" ,pkg-config)))
> +    (home-page "http://www.bluestop.org/wmclock/")

Debian lists http://windowmaker.org/dockapps/?name=wmclock as the homepage, and they provide 1.0.16, unlike bluestop which stops at 1.0.14.

I don't think I would use them for the download url though, pasting theirs in
wget gave me
http://repo.or.cz/w/dockapps.git/snapshot/daaf3aa04e55152d4c2ec002cabefe7e2026b150.tar.gz

> +    (synopsis "Display the date and time")
> +    (description
> +     "wmclock is an applet for Window Maker which displays the date and time in
> +a dockable tile.  It features multiple language support, 24h or 12h time
> +display, and can run a user-specified program on mouse click.")
> +    (license gpl2+)))



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] gnu: Add wmclock.

[Kei Yamashita]

On Thu, 07 Apr 2016 19:09:39 +0200
Mathieu Lirzin <mthl@gnu.org> wrote:

> Hello,
> 
> Kei Yamashita <kei@openmailbox.org> writes:
> 
> > From 15c0f48c3b9c510228a95655e11f95dbca5fbf91 Mon Sep 17 00:00:00
> > 2001 From: Kei Yamashita <kei@openmailbox.org>
> > Date: Thu, 7 Apr 2016 12:53:43 -0400
> > Subject: [PATCH] gnu: Add wmclock.
> >
> > * gnu/packages/gnustep.scm (wmclock): New variable.
> > ---  
> 
> > +    (build-system gnu-build-system)
> > +    (arguments
> > +     `(#:phases
> > +       (modify-phases %standard-phases
> > +         (add-after 'unpack 'autoconf
> > +           (lambda _ (zero? (system* "autoreconf" "-vfi")))))))  
> 
> Does the tarball contains a configure script?  If not or if it is not
> possible to use it, please provide a commentary to explain why
> maintainer tools are required since this is not a expected behavior.
> 
> Thanks,
> 

The tarball requires autoconf to create the configure script. Should I
just include that as a comment?

Re: [PATCH] gnu: Add wmclock.

[Kei Yamashita]

On Thu, 7 Apr 2016 20:31:48 +0300
Efraim Flashner <efraim@flashner.co.il> wrote:

> On Thu, 7 Apr 2016 12:57:15 -0400
> Kei Yamashita <kei@openmailbox.org> wrote:
> 
> > From 15c0f48c3b9c510228a95655e11f95dbca5fbf91 Mon Sep 17 00:00:00
> > 2001 From: Kei Yamashita <kei@openmailbox.org>
> > Date: Thu, 7 Apr 2016 12:53:43 -0400
> > Subject: [PATCH] gnu: Add wmclock.
> > 
> > * gnu/packages/gnustep.scm (wmclock): New variable.
> > ---
> >  gnu/packages/gnustep.scm | 34 ++++++++++++++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> > 
> > diff --git a/gnu/packages/gnustep.scm b/gnu/packages/gnustep.scm
> > index 8c43085..4977507 100644
> > --- a/gnu/packages/gnustep.scm
> > +++ b/gnu/packages/gnustep.scm
> > @@ -181,3 +181,37 @@ on and off by clicking the mouse button over
> > the application.  If the CPU usage hits a certain threshold, an
> > alarm-mode will alert you by turning back-light on.")
> >      (license gpl2+)))
> > +
> > +(define-public wmclock
> > +  (package
> > +    (name "wmclock")
> > +    (version "1.0.16")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append
> > +                    "mirror://debian/pool/main/w/wmclock/"
> > +                    name "_" version ".orig.tar.gz"))
> > +              (sha256
> > +               (base32
> > +
> > "1lx276ba8r2yydhmwj1g586jdqg695ad89ng36fr3mb067gvb2rz"))))
> > +    (build-system gnu-build-system)
> > +    (arguments
> > +     `(#:phases
> > +       (modify-phases %standard-phases
> > +         (add-after 'unpack 'autoconf
> > +           (lambda _ (zero? (system* "autoreconf" "-vfi")))))))
> > +    (inputs
> > +     `(("libx11" ,libx11)
> > +       ("libxext" ,libxext)
> > +       ("libxpm" ,libxpm)))
> > +    (native-inputs
> > +     `(("autoconf" ,autoconf)
> > +       ("automake" ,automake)
> > +       ("pkg-config" ,pkg-config)))
> > +    (home-page "http://www.bluestop.org/wmclock/")  
> 
> Debian lists http://windowmaker.org/dockapps/?name=wmclock as the
> homepage, and they provide 1.0.16, unlike bluestop which stops at
> 1.0.14.
> 
> I don't think I would use them for the download url though, pasting
> theirs in wget gave me
> http://repo.or.cz/w/dockapps.git/snapshot/daaf3aa04e55152d4c2ec002cabefe7e2026b150.tar.gz
> 
> > +    (synopsis "Display the date and time")
> > +    (description
> > +     "wmclock is an applet for Window Maker which displays the
> > date and time in +a dockable tile.  It features multiple language
> > support, 24h or 12h time +display, and can run a user-specified
> > program on mouse click.")
> > +    (license gpl2+)))  
> 
> 
> 

My mistake. I meant to use the Window Maker developers' page as the
home page. I'll submit a new patch with the necessary changes (waiting
on Mathieu's response).

Re: [PATCH] gnu: Add wmclock.

[Kei Yamashita]

[-- Attachment #1: Type: text/plain, Size: 3123 bytes --]

On Thu, 7 Apr 2016 13:56:50 -0400
Kei Yamashita <kei@openmailbox.org> wrote:

> On Thu, 7 Apr 2016 20:31:48 +0300
> Efraim Flashner <efraim@flashner.co.il> wrote:
> 
> > On Thu, 7 Apr 2016 12:57:15 -0400
> > Kei Yamashita <kei@openmailbox.org> wrote:
> >   
> > > From 15c0f48c3b9c510228a95655e11f95dbca5fbf91 Mon Sep 17 00:00:00
> > > 2001 From: Kei Yamashita <kei@openmailbox.org>
> > > Date: Thu, 7 Apr 2016 12:53:43 -0400
> > > Subject: [PATCH] gnu: Add wmclock.
> > > 
> > > * gnu/packages/gnustep.scm (wmclock): New variable.
> > > ---
> > >  gnu/packages/gnustep.scm | 34 ++++++++++++++++++++++++++++++++++
> > >  1 file changed, 34 insertions(+)
> > > 
> > > diff --git a/gnu/packages/gnustep.scm b/gnu/packages/gnustep.scm
> > > index 8c43085..4977507 100644
> > > --- a/gnu/packages/gnustep.scm
> > > +++ b/gnu/packages/gnustep.scm
> > > @@ -181,3 +181,37 @@ on and off by clicking the mouse button over
> > > the application.  If the CPU usage hits a certain threshold, an
> > > alarm-mode will alert you by turning back-light on.")
> > >      (license gpl2+)))
> > > +
> > > +(define-public wmclock
> > > +  (package
> > > +    (name "wmclock")
> > > +    (version "1.0.16")
> > > +    (source (origin
> > > +              (method url-fetch)
> > > +              (uri (string-append
> > > +                    "mirror://debian/pool/main/w/wmclock/"
> > > +                    name "_" version ".orig.tar.gz"))
> > > +              (sha256
> > > +               (base32
> > > +
> > > "1lx276ba8r2yydhmwj1g586jdqg695ad89ng36fr3mb067gvb2rz"))))
> > > +    (build-system gnu-build-system)
> > > +    (arguments
> > > +     `(#:phases
> > > +       (modify-phases %standard-phases
> > > +         (add-after 'unpack 'autoconf
> > > +           (lambda _ (zero? (system* "autoreconf" "-vfi")))))))
> > > +    (inputs
> > > +     `(("libx11" ,libx11)
> > > +       ("libxext" ,libxext)
> > > +       ("libxpm" ,libxpm)))
> > > +    (native-inputs
> > > +     `(("autoconf" ,autoconf)
> > > +       ("automake" ,automake)
> > > +       ("pkg-config" ,pkg-config)))
> > > +    (home-page "http://www.bluestop.org/wmclock/")    
> > 
> > Debian lists http://windowmaker.org/dockapps/?name=wmclock as the
> > homepage, and they provide 1.0.16, unlike bluestop which stops at
> > 1.0.14.
> > 
> > I don't think I would use them for the download url though, pasting
> > theirs in wget gave me
> > http://repo.or.cz/w/dockapps.git/snapshot/daaf3aa04e55152d4c2ec002cabefe7e2026b150.tar.gz
> >   
> > > +    (synopsis "Display the date and time")
> > > +    (description
> > > +     "wmclock is an applet for Window Maker which displays the
> > > date and time in +a dockable tile.  It features multiple language
> > > support, 24h or 12h time +display, and can run a user-specified
> > > program on mouse click.")
> > > +    (license gpl2+)))    
> > 
> > 
> >   
> 
> My mistake. I meant to use the Window Maker developers' page as the
> home page. I'll submit a new patch with the necessary changes (waiting
> on Mathieu's response).
> 

This new patch specifies why autoreconf is necessary and corrects the
home page error.

[-- Attachment #2: 0001-gnu-Add-wmclock.patch --]
[-- Type: application/octet-stream, Size: 2004 bytes --]

From f87341a0afe47f942940c96c34b9c9525b34e249 Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Fri, 8 Apr 2016 09:34:02 -0400
Subject: [PATCH] gnu: Add wmclock.

* gnu/packages/gnustep.scm (wmclock): New variable.
---
 gnu/packages/gnustep.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/gnustep.scm b/gnu/packages/gnustep.scm
index 8c43085..f4a2b26 100644
--- a/gnu/packages/gnustep.scm
+++ b/gnu/packages/gnustep.scm
@@ -181,3 +181,38 @@ on and off by clicking the mouse button over the application.  If the CPU usage
 hits a certain threshold, an alarm-mode will alert you by turning back-light
 on.")
     (license gpl2+)))
+
+(define-public wmclock
+  (package
+    (name "wmclock")
+    (version "1.0.16")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://debian/pool/main/w/wmclock/"
+                    name "_" version ".orig.tar.gz"))
+              (sha256
+               (base32
+                "1lx276ba8r2yydhmwj1g586jdqg695ad89ng36fr3mb067gvb2rz"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'autoconf
+           (lambda _ (zero? (system* "autoreconf" "-vfi")))))))
+    ;; wmclock requires autoreconf to generate its configure script.
+    (inputs
+     `(("libx11" ,libx11)
+       ("libxext" ,libxext)
+       ("libxpm" ,libxpm)))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("pkg-config" ,pkg-config)))
+    (home-page "http://windowmaker.org/dockapps/?name=wmclock")
+    (synopsis "Display the date and time")
+    (description
+     "wmclock is an applet for Window Maker which displays the date and time in
+a dockable tile.  It features multiple language support, 24h or 12h time
+display, and can run a user-specified program on mouse click.")
+    (license gpl2+)))
-- 
2.7.3

Re: [PATCH] gnu: Add wmclock.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 3678 bytes --]

On Fri, Apr 08, 2016 at 09:35:52AM -0400, Kei Yamashita wrote:
> On Thu, 7 Apr 2016 13:56:50 -0400
> Kei Yamashita <kei@openmailbox.org> wrote:
> 
> > On Thu, 7 Apr 2016 20:31:48 +0300
> > Efraim Flashner <efraim@flashner.co.il> wrote:
> > 
> > > On Thu, 7 Apr 2016 12:57:15 -0400
> > > Kei Yamashita <kei@openmailbox.org> wrote:
> > >   
> > > > From 15c0f48c3b9c510228a95655e11f95dbca5fbf91 Mon Sep 17 00:00:00
> > > > 2001 From: Kei Yamashita <kei@openmailbox.org>
> > > > Date: Thu, 7 Apr 2016 12:53:43 -0400
> > > > Subject: [PATCH] gnu: Add wmclock.
> > > > 
> > > > * gnu/packages/gnustep.scm (wmclock): New variable.
> > > > ---
> > > >  gnu/packages/gnustep.scm | 34 ++++++++++++++++++++++++++++++++++
> > > >  1 file changed, 34 insertions(+)
> > > > 
> > > > diff --git a/gnu/packages/gnustep.scm b/gnu/packages/gnustep.scm
> > > > index 8c43085..4977507 100644
> > > > --- a/gnu/packages/gnustep.scm
> > > > +++ b/gnu/packages/gnustep.scm
> > > > @@ -181,3 +181,37 @@ on and off by clicking the mouse button over
> > > > the application.  If the CPU usage hits a certain threshold, an
> > > > alarm-mode will alert you by turning back-light on.")
> > > >      (license gpl2+)))
> > > > +
> > > > +(define-public wmclock
> > > > +  (package
> > > > +    (name "wmclock")
> > > > +    (version "1.0.16")
> > > > +    (source (origin
> > > > +              (method url-fetch)
> > > > +              (uri (string-append
> > > > +                    "mirror://debian/pool/main/w/wmclock/"
> > > > +                    name "_" version ".orig.tar.gz"))
> > > > +              (sha256
> > > > +               (base32
> > > > +
> > > > "1lx276ba8r2yydhmwj1g586jdqg695ad89ng36fr3mb067gvb2rz"))))
> > > > +    (build-system gnu-build-system)
> > > > +    (arguments
> > > > +     `(#:phases
> > > > +       (modify-phases %standard-phases
> > > > +         (add-after 'unpack 'autoconf
> > > > +           (lambda _ (zero? (system* "autoreconf" "-vfi")))))))
> > > > +    (inputs
> > > > +     `(("libx11" ,libx11)
> > > > +       ("libxext" ,libxext)
> > > > +       ("libxpm" ,libxpm)))
> > > > +    (native-inputs
> > > > +     `(("autoconf" ,autoconf)
> > > > +       ("automake" ,automake)
> > > > +       ("pkg-config" ,pkg-config)))
> > > > +    (home-page "http://www.bluestop.org/wmclock/")    
> > > 
> > > Debian lists http://windowmaker.org/dockapps/?name=wmclock as the
> > > homepage, and they provide 1.0.16, unlike bluestop which stops at
> > > 1.0.14.
> > > 
> > > I don't think I would use them for the download url though, pasting
> > > theirs in wget gave me
> > > http://repo.or.cz/w/dockapps.git/snapshot/daaf3aa04e55152d4c2ec002cabefe7e2026b150.tar.gz
> > >   
> > > > +    (synopsis "Display the date and time")
> > > > +    (description
> > > > +     "wmclock is an applet for Window Maker which displays the
> > > > date and time in +a dockable tile.  It features multiple language
> > > > support, 24h or 12h time +display, and can run a user-specified
> > > > program on mouse click.")
> > > > +    (license gpl2+)))    
> > > 
> > > 
> > >   
> > 
> > My mistake. I meant to use the Window Maker developers' page as the
> > home page. I'll submit a new patch with the necessary changes (waiting
> > on Mathieu's response).
> > 
> 
> This new patch specifies why autoreconf is necessary and corrects the
> home page error.

Looks good! patch pushed

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]