From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [Patch] gst-plugins-base Date: Thu, 31 Mar 2016 10:22:16 +0300 Message-ID: <20160331072216.GE7964@debian-netbook> References: <20160330183809.29bd3b17@debian-netbook> <87shz71vlh.fsf@netris.org> <87lh4z1vej.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="L2Brqb15TUChFOBK" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alWvx-0001hQ-Aw for guix-devel@gnu.org; Thu, 31 Mar 2016 03:22:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alWvs-0004qN-7G for guix-devel@gnu.org; Thu, 31 Mar 2016 03:22:25 -0400 Received: from flashner.co.il ([178.62.234.194]:57181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alWvr-0004qJ-SK for guix-devel@gnu.org; Thu, 31 Mar 2016 03:22:20 -0400 Content-Disposition: inline In-Reply-To: <87lh4z1vej.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org --L2Brqb15TUChFOBK Content-Type: multipart/mixed; boundary="n+lFg1Zro7sl44OB" Content-Disposition: inline --n+lFg1Zro7sl44OB Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 30, 2016 at 05:57:24PM -0400, Mark H Weaver wrote: > Mark H Weaver writes: >=20 > > Here's one way to do it: > > > > (inputs > > `(("cdparanoia" ,cdparanoia) > > ,@(if (any (cute string-prefix? <> (or (%current-target-system) > > (%current-system))) > > '("arm" "mips")) 64-bit Arm is Aarch64 and not arm64, so this probably won't capture 64-bit Arm if/when we start to support it. > > '() > > `(("orc" ,orc))) > > > > You'll need to import (srfi srfi-1) for 'any' and (srfi srfi-26) for > > 'cute'. > > > > What do you think? Can you send an updated patch? >=20 > One more thing: please add a comment containing the string "FIXME", > explaining that we are omitting "orc" on arm and mips, and the reason > why. >=20 > Thanks! > Mark It turns out I didn't search gstreamer.scm well enough, so if this patch looks good then I'll copy the syntax over to the other packages in gstreamer and make patches for them too. efraim@debian-netbook:~/workspace/guix$ grep \(\"orc\"\ \,orc\) gnu/packages/*scm gnu/packages/gstreamer.scm: `(("orc" ,orc))) gnu/packages/gstreamer.scm: ("orc" ,orc) gnu/packages/gstreamer.scm: ("orc" ,orc) gnu/packages/gstreamer.scm: ("orc" ,orc))) gnu/packages/gstreamer.scm: ("orc" ,orc) --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --n+lFg1Zro7sl44OB Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-gnu-gst-plugins-base-Don-t-build-with-orc-on-arm-mip.patch" Content-Transfer-Encoding: quoted-printable =46rom b368c9c2c9948d32bb9167cd4e07aa4d49fa2d44 Mon Sep 17 00:00:00 2001 =46rom: Efraim Flashner Date: Wed, 30 Mar 2016 18:03:53 +0300 Subject: [PATCH] gnu: gst-plugins-base: Don't build with orc on arm/mips architectures. * gnu/packages/gstreamer.scm (gst-plugins-base)[inputs]: Only use orc as an input on armhf or mips architectures. --- gnu/packages/gstreamer.scm | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm index 5cf59cd..3694e6c 100644 --- a/gnu/packages/gstreamer.scm +++ b/gnu/packages/gstreamer.scm @@ -58,7 +58,9 @@ #:use-module (gnu packages tls) #:use-module (gnu packages version-control) #:use-module (gnu packages yasm) - #:use-module (gnu packages xml)) + #:use-module (gnu packages xml) + #:use-module (srfi srfi-1) + #:use-module (srfi srfi-26)) =20 (define-public orc (package @@ -160,7 +162,14 @@ This package provides the core library and elements.") `(("gstreamer" ,gstreamer))) ; required by gstreamer-plugins-base-1.0= =2Epc (inputs `(("cdparanoia" ,cdparanoia) - ("orc" ,orc) + ;; FIXME: On arm the orc related tests fail, and on mips "orc" fail= s to + ;; build. For the time being we are disabling "orc" as an input on + ;; these architectures. + ,@(if (any (cute string-prefix? <> (or (%current-target-system) + (%current-system))) + '("arm" "mips")) + '() + `(("orc" ,orc))) ("pango" ,pango) ("libogg" ,libogg) ("libtheora" ,libtheora) --=20 2.8.0.rc3 --n+lFg1Zro7sl44OB-- --L2Brqb15TUChFOBK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJW/NAlAAoJEPTB05F+rO6TioUP/R6f9ELYGqxbj0fYaZmgaUpr I9ncCmEAQQ52A6b05IRZ3UYRbh1BgNc4S2Jw0ITBat3mdfCdcRusg/jv36L7y+QQ HoACpYAVzu6k/v+7oY6ay8BY48rLMuTHuNzEDmotms6Wwr8Bedo71tSnv5DdJzwV DLnC5PlpVjMvd318+Lhz2H40B7QXuq36rydLCvQ0cxuPJ13AQHNkcgsEI8jbnBKG kmvxB4kmSt7fmdIITdvL/s9xU8BCKeTwdciJ2j7pJ8xpeSIny5hrhy80yhJLsqi4 l7Ew7eZOoUeJtzjJ4TCJRJu0MXJCaYzcpEBsZXciFpAuYyT1BvqduY07s959SWFK wyKaS3BH6HOPS6ajsdPSxbAFwyeWtTgAJu/Qg7uq0jqZahWWElSkJuetMGG7Esza VtbvgwxTMFouPp1Yl4oenuYlHTtcbLWL2+txm5itJejW92y+BgLs2rLoumMSaAet MvzJ2TrZMFX2GeZGRdteUFDcYyq5/ADqtOmP28/nTSNBW/vM4I+tJGAIvWepeP18 FLuNO8rHndVnlUBYop6P4zx0Ydr46i8pNaf+s4XL9PjuoI1FnOs9w60JURiNRQM5 plzmdc1cjHObjHsVpSeEnFUow3NiC4sqeJQGf40RKlHwYokgKlM3Aiicp0DeafNh 8N82ZNQcLZjZUd3nhx/b =doII -----END PGP SIGNATURE----- --L2Brqb15TUChFOBK--