From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add 4store.
Date: Mon, 28 Mar 2016 12:16:24 -0400
Message-ID: <20160328161624.GA7959@jasmine>
References: <8760wd5lqt.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33067)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1akZq8-0005zK-9i
	for guix-devel@gnu.org; Mon, 28 Mar 2016 12:16:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1akZq5-0007GT-3C
	for guix-devel@gnu.org; Mon, 28 Mar 2016 12:16:28 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42071)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1akZq4-0007GO-Nk
	for guix-devel@gnu.org; Mon, 28 Mar 2016 12:16:25 -0400
Content-Disposition: inline
In-Reply-To: <8760wd5lqt.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org

On Wed, Mar 23, 2016 at 03:09:46PM +0100, Roel Janssen wrote:
> * gnu/packages/databases.scm (4store): New variable.
> * gnu/packages/patches/4store-fix-buildsystem.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add patch file entry.

[...]

> +(define-public 4store
> +  (let ((commit "c5a56d7c7504551a1f2fff6c16c4d9a440e4a317"))
> +    (package
> +      (name "4store")
> +      (version (string-append "1.1.6-0." (string-take commit 7)))

Why use this commit instead of the last release?

> Dear Guix,
> 
> I would like to add 4store.  The official website is currently offline,
> but there is an effort going on to get it back on line:
>   https://github.com/garlik/4store/issues/137
> 
> Therefore, I would like to propose to keep the dead website link as this
> should sort itself out in time.

I think this makes sense. Try to remember to follow up on the resolution
of that bug report :)

> I had to patch some build system files to avoid the need for Git and to
> avoid "mkdir -p /var/lib/4store".

Thanks, it's super annoying when the git metadata is required.