unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: pspp: Update to 0.10.0
@ 2016-03-27  6:24 John Darrington
  2016-03-27  7:00 ` Efraim Flashner
  0 siblings, 1 reply; 6+ messages in thread
From: John Darrington @ 2016-03-27  6:24 UTC (permalink / raw)
  To: guix-devel; +Cc: John Darrington

* gnu/packages/math.scm (pspp): Update to 0.10.0
---
 gnu/packages/maths.scm | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 6d3d134..659d8a2 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -43,6 +43,8 @@
   #:use-module (gnu packages check)
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages databases)
+  #:use-module (gnu packages ncurses)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages elf)
   #:use-module (gnu packages flex)
@@ -204,15 +206,14 @@ LP/MIP solver is included in the package.")
 (define-public pspp
   (package
     (name "pspp")
-    (version "0.8.5")
+    (version "0.10.0")
     (source
      (origin
       (method url-fetch)
-      (uri (string-append "mirror://gnu/pspp/pspp-"
-                          version ".tar.gz"))
+      (uri (string-append "mirror://gnu/pspp/pspp-" version ".tar.gz"))
       (sha256
        (base32
-        "0c8326yykidi94xi7jn27j8iqxc38vc07d4wf5zyk0l8lpzx5vz7"))))
+         "1nwnxr8mvf8y4lc8h8sd2xn2njwjk42x8mzj91zzv92m2z3vyggg"))))
     (build-system gnu-build-system)
     (inputs
      `(("cairo" ,cairo)
@@ -220,14 +221,18 @@ LP/MIP solver is included in the package.")
        ("gettext" ,gnu-gettext)
        ("gsl" ,gsl)
        ("libxml2" ,libxml2)
+       ("ncurses" ,ncurses)
        ("pango" ,pango)
+       ("postgresql",postgresql) ; for the libpq interface
        ("readline" ,readline)
-       ("gtk" ,gtk+-2)
-       ("gtksourceview" ,gtksourceview-2)
+       ("gtk" ,gtk+)
+       ("gtksourceview" ,gtksourceview)
        ("zlib" ,zlib)))
     (native-inputs
      `(("glib" ,glib "bin")             ;for glib-genmarshal
        ("perl" ,perl)
+       ("perl-text-diff" ,perl-text-diff)
+       ("postgresql",postgresql) ; Need a postgres server to test the libpq interface
        ("texinfo" ,texinfo)
        ("pkg-config" ,pkg-config)))
     (home-page "http://www.gnu.org/software/pspp/")
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: pspp: Update to 0.10.0
  2016-03-27  6:24 [PATCH] gnu: pspp: Update to 0.10.0 John Darrington
@ 2016-03-27  7:00 ` Efraim Flashner
  2016-03-27  7:14   ` John Darrington
  0 siblings, 1 reply; 6+ messages in thread
From: Efraim Flashner @ 2016-03-27  7:00 UTC (permalink / raw)
  To: John Darrington; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 2737 bytes --]

On Sun, 27 Mar 2016 08:24:52 +0200
John Darrington <jmd@gnu.org> wrote:

> * gnu/packages/math.scm (pspp): Update to 0.10.0
> ---
>  gnu/packages/maths.scm | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 6d3d134..659d8a2 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -43,6 +43,8 @@
>    #:use-module (gnu packages check)
>    #:use-module (gnu packages cmake)
>    #:use-module (gnu packages compression)
> +  #:use-module (gnu packages databases)
> +  #:use-module (gnu packages ncurses)
>    #:use-module (gnu packages curl)
>    #:use-module (gnu packages elf)
>    #:use-module (gnu packages flex)
> @@ -204,15 +206,14 @@ LP/MIP solver is included in the package.")
>  (define-public pspp
>    (package
>      (name "pspp")
> -    (version "0.8.5")
> +    (version "0.10.0")
>      (source
>       (origin
>        (method url-fetch)
> -      (uri (string-append "mirror://gnu/pspp/pspp-"
> -                          version ".tar.gz"))
> +      (uri (string-append "mirror://gnu/pspp/pspp-" version ".tar.gz"))
>        (sha256
>         (base32
> -        "0c8326yykidi94xi7jn27j8iqxc38vc07d4wf5zyk0l8lpzx5vz7"))))
> +         "1nwnxr8mvf8y4lc8h8sd2xn2njwjk42x8mzj91zzv92m2z3vyggg"))))
>      (build-system gnu-build-system)
>      (inputs
>       `(("cairo" ,cairo)
> @@ -220,14 +221,18 @@ LP/MIP solver is included in the package.")
>         ("gettext" ,gnu-gettext)
>         ("gsl" ,gsl)
>         ("libxml2" ,libxml2)
> +       ("ncurses" ,ncurses)
>         ("pango" ,pango)
> +       ("postgresql",postgresql) ; for the libpq interface
>         ("readline" ,readline)
> -       ("gtk" ,gtk+-2)
> -       ("gtksourceview" ,gtksourceview-2)
> +       ("gtk" ,gtk+)
> +       ("gtksourceview" ,gtksourceview)
>         ("zlib" ,zlib)))
>      (native-inputs
>       `(("glib" ,glib "bin")             ;for glib-genmarshal
>         ("perl" ,perl)
> +       ("perl-text-diff" ,perl-text-diff)
> +       ("postgresql",postgresql) ; Need a postgres server to test the libpq interface
>         ("texinfo" ,texinfo)
>         ("pkg-config" ,pkg-config)))
>      (home-page "http://www.gnu.org/software/pspp/")

I pushed an update to pspp last night and I had the changes from gtk2 to
gtk3, but I don't have the ncurses, postgresql or perl-text-diff additions.
Are they all related to the libpq interface, and what is it?

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: pspp: Update to 0.10.0
  2016-03-27  7:00 ` Efraim Flashner
@ 2016-03-27  7:14   ` John Darrington
  2016-03-27 17:33     ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: John Darrington @ 2016-03-27  7:14 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: guix-devel, John Darrington

[-- Attachment #1: Type: text/plain, Size: 938 bytes --]

On Sun, Mar 27, 2016 at 10:00:04AM +0300, Efraim Flashner wrote:

     I pushed an update to pspp last night and I had the changes from gtk2 to
     gtk3, but I don't have the ncurses, postgresql or perl-text-diff additions.
     Are they all related to the libpq interface, and what is it?

ncurses is optional for pspp - the terminal behaviour is nicer if you have it.

perl-text-diff is not used by pspp except in its self tests.  There is one test
which needs it.  If you don't have it that test is skipped.

Postgres ships with a client interface library called libpq - using it is optional
in pspp.  If you have it, it allows pspp to directly connect to postgres databases.


J'
     

-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: pspp: Update to 0.10.0
  2016-03-27  7:14   ` John Darrington
@ 2016-03-27 17:33     ` Ludovic Courtès
  2016-03-28  7:45       ` John Darrington
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2016-03-27 17:33 UTC (permalink / raw)
  To: John Darrington; +Cc: guix-devel, John Darrington

John Darrington <john@darrington.wattle.id.au> skribis:

> ncurses is optional for pspp - the terminal behaviour is nicer if you have it.
>
> perl-text-diff is not used by pspp except in its self tests.  There is one test
> which needs it.  If you don't have it that test is skipped.
>
> Postgres ships with a client interface library called libpq - using it is optional
> in pspp.  If you have it, it allows pspp to directly connect to postgres databases.

Could you post an updated patch?

I guess the PostgreSQL dependency might be debatable since it would
probably significantly increase the closure size.  Could you check ‘guix
size’ and decide whether adding this dependency is a good thing, based
on its size/benefit ratio?   :-)

TIA!

Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: pspp: Update to 0.10.0
  2016-03-27 17:33     ` Ludovic Courtès
@ 2016-03-28  7:45       ` John Darrington
  2016-03-28 16:46         ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: John Darrington @ 2016-03-28  7:45 UTC (permalink / raw)
  To: Ludovic Court??s; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

On Sun, Mar 27, 2016 at 07:33:10PM +0200, Ludovic Court??s wrote:
     John Darrington <john@darrington.wattle.id.au> skribis:
     
     > Postgres ships with a client interface library called libpq - using it is optional
     > in pspp.  If you have it, it allows pspp to directly connect to postgres databases.
     
     I guess the PostgreSQL dependency might be debatable since it would
     probably significantly increase the closure size.  Could you check ???guix
     size??? and decide whether adding this dependency is a good thing, based
     on its size/benefit ratio?   :-)
     
For this reasons, most distos which ship postgres put the libpq &c in a seperate package.
Guix so far as I can see is the only one which does not.  Should we split postgres into
two (or more) outputs ?

J'

-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: pspp: Update to 0.10.0
  2016-03-28  7:45       ` John Darrington
@ 2016-03-28 16:46         ` Ludovic Courtès
  0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2016-03-28 16:46 UTC (permalink / raw)
  To: John Darrington; +Cc: guix-devel

John Darrington <john@darrington.wattle.id.au> skribis:

> On Sun, Mar 27, 2016 at 07:33:10PM +0200, Ludovic Court??s wrote:
>      John Darrington <john@darrington.wattle.id.au> skribis:
>      
>      > Postgres ships with a client interface library called libpq - using it is optional
>      > in pspp.  If you have it, it allows pspp to directly connect to postgres databases.
>      
>      I guess the PostgreSQL dependency might be debatable since it would
>      probably significantly increase the closure size.  Could you check ???guix
>      size??? and decide whether adding this dependency is a good thing, based
>      on its size/benefit ratio?   :-)
>      
> For this reasons, most distos which ship postgres put the libpq &c in a seperate package.
> Guix so far as I can see is the only one which does not.  Should we split postgres into
> two (or more) outputs ?

Why not, again depending on the cost/benefit ratio in terms of closure
size and usability.

Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-03-28 16:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-27  6:24 [PATCH] gnu: pspp: Update to 0.10.0 John Darrington
2016-03-27  7:00 ` Efraim Flashner
2016-03-27  7:14   ` John Darrington
2016-03-27 17:33     ` Ludovic Courtès
2016-03-28  7:45       ` John Darrington
2016-03-28 16:46         ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).