Re: [PATCH] Add MilkyTracker to Guix

[Kei Yamashita <kei@openmailbox.org>]

On Sun, 27 Mar 2016 10:23:37 +0300
Efraim Flashner <efraim@flashner.co.il> wrote:

> On Fri, Mar 25, 2016 at 07:54:40PM -0400, kei@openmailbox.org wrote:
> > The attached is a patch to gnu/packages/music.scm that allows a
> > minimal and functional build of MilkyTracker. I'm unsure if this is
> > formatted correctly, but I'm willing to learn. :-)  
> 
> > --- music.scm.bak	2016-03-25 17:39:35.959715114 -0400
> > +++ music.scm	2016-03-25 19:39:44.754396091 -0400
> > @@ -78,6 +78,7 @@
> >    #:use-module (gnu packages rdf)
> >    #:use-module (gnu packages readline)
> >    #:use-module (gnu packages rsync)
> > +  #:use-module (gnu packages sdl)
> >    #:use-module (gnu packages tcl)
> >    #:use-module (gnu packages texinfo)
> >    #:use-module (gnu packages texlive)
> > @@ -1305,3 +1306,26 @@
> >  of tools for manipulating and accessing your music.")
> >      (license license:expat)))
> >  
> > +(define-public milkytracker
> > +  (package
> > +    (name "milkytracker")
> > +    (version "0.90.86")
> > +    (source (origin
> > +	      (method url-fetch)
> > +	      (uri
> > +	       (string-append
> > "http://milkytracker.org/files/milkytracker-"
> > +				  version
> > +				  ".tar.gz"))
> > +              (sha256
> > +               (base32
> > +
> > "0mqjkhvjyp5hnzm1ln3b2qjclviayxylcyml96pjdxgbaqcqa2zz"))))
> > +    (build-system gnu-build-system)
> > +    (arguments
> > +     '(#:configure-flags `("--without-alsa" "--without-jack")))
> > +    (inputs
> > +     `(("sdl" ,sdl)
> > +       ("zlib" ,zlib)))
> > +    (synopsis "MilkyTracker is a free software multi-platform
> > music tracker for composing music in the MOD and XM module file
> > formats.")
> > +    (description "MilkyTracker is a free software, multi-platform
> > music application for creating .MOD and .XM module files. It
> > attempts to recreate the module replay and user experience of the
> > popular DOS program Fasttracker II, with special playback modes
> > available for improved Amiga ProTracker 2/3 compatibility.")
> > +    (home-page "http://milkytracker.org/")
> > +    (license license:gpl3)))  
> 
> In addition to Nil's comments, I was wondering about the configure
> flags. Wouldn't it make sense to have either alsa or jack as an input?
> 

Milkytracker works fine without it on my machine. I feel like it's a
matter of allowing the user options or sticking to the minimal build.