From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 13/13] gnu: Add beets. Date: Sun, 27 Mar 2016 18:25:26 -0400 Message-ID: <20160327222526.GA18750@jasmine> References: <20160318182939.GB32474@jasmine> <87io0ak0gq.fsf@netris.org> <20160325172659.GA10248@jasmine> <1458949048.4102608.559959178.4ED1819C@webmail.messagingengine.com> <20160326003020.GB3676@jasmine> <87io0931rk.fsf@gnu.org> <1459004312.934516.560284258.4584E406@webmail.messagingengine.com> <20160327213619.GB29056@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akJ7j-0002eD-NV for guix-devel@gnu.org; Sun, 27 Mar 2016 18:25:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akJ7g-00060V-E1 for guix-devel@gnu.org; Sun, 27 Mar 2016 18:25:31 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akJ7g-00060Q-8M for guix-devel@gnu.org; Sun, 27 Mar 2016 18:25:28 -0400 Content-Disposition: inline In-Reply-To: <20160327213619.GB29056@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Griffin Cc: guix-devel@gnu.org On Sun, Mar 27, 2016 at 05:36:19PM -0400, Leo Famulari wrote: > On Sat, Mar 26, 2016 at 09:58:32AM -0500, Alex Griffin wrote: > > I tried building with --rounds=4 on my GuixSD machine, but it errored > > out after the first build with the same error. Then I tried building > > with --check on my Debian machine and it succeeded. > > > > Last night on IRC we were discussing this more and I think Leo was going > > to try incorporating something from the nixos beets package, or else > > wait until the beets developers could help him. > > On IRC, (the user who I think is) Alex said that they were able to build > beets with the attached patch. > > All the patch does is invoke the tests with `nosetests -v` instead of > `python setup.py test`, making use of python2-nose. This is what is done > by Nixpkgs. > > Is there anybody else who could not build beets before? Would you like > to test the patch? And now I see that the beets wiki says that the tests are to be run with nose: https://github.com/beetbox/beets/wiki/Testing So, I applied the patch as 36c2c8c82. > > > -- > > Alex Griffin > > > > > > On Sat, Mar 26, 2016, at 06:41 AM, Ludovic Courtès wrote: > > > Leo Famulari skribis: > > > > > > > Can you try building with '#:parallel-tests? #f', as shown in this link? > > > > > > I was also going to suggest something along these lines. > > > > > > Could you try building with with --rounds=4, say, on your machine? (Or > > > --check if it’s already there.) > > > > > > Thanks, > > > Ludo’. > From ba2cb8403ab9340ab8a6da534e9db4cc3f2fbb84 Mon Sep 17 00:00:00 2001 > From: Leo Famulari > Date: Sat, 26 Mar 2016 17:53:59 -0400 > Subject: [PATCH] gnu: beets: Run tests with python-nose. > > * gnu/packages/music.scm (nose)[native-inputs]: Add python-nose. > [arguments]: Replace 'check' and use python-nose. > --- > gnu/packages/music.scm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm > index 89f49c6..48d6214 100644 > --- a/gnu/packages/music.scm > +++ b/gnu/packages/music.scm > @@ -1274,13 +1274,16 @@ websites such as Libre.fm.") > #:phases > (modify-phases %standard-phases > (add-after 'unpack 'set-HOME > - (lambda _ (setenv "HOME" (string-append (getcwd) "/tmp"))))))) > + (lambda _ (setenv "HOME" (string-append (getcwd) "/tmp")))) > + (replace 'check > + (lambda _ (zero? (system* "nosetests" "-v"))))))) > (native-inputs > `(("python2-beautifulsoup4" ,python2-beautifulsoup4) > ("python2-flask" ,python2-flask) > ("python2-setuptools" ,python2-setuptools) > ("python2-mock" ,python2-mock) > ("python2-mpd2" ,python2-mpd2) > + ("python2-nose" ,python2-nose) > ("python2-pathlib" ,python2-pathlib) > ("python2-pyxdg" ,python2-pyxdg) > ("python2-pyechonest" ,python2-pyechonest) > -- > 2.7.3 >