Re: [PATCH 13/13] gnu: Add beets.

[Leo Famulari <leo@famulari.name>]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

On Sat, Mar 26, 2016 at 09:58:32AM -0500, Alex Griffin wrote:
> I tried building with --rounds=4 on my GuixSD machine, but it errored
> out after the first build with the same error. Then I tried building
> with --check on my Debian machine and it succeeded.
> 
> Last night on IRC we were discussing this more and I think Leo was going
> to try incorporating something from the nixos beets package, or else
> wait until the beets developers could help him.

On IRC, (the user who I think is) Alex said that they were able to build
beets with the attached patch.

All the patch does is invoke the tests with `nosetests -v` instead of
`python setup.py test`, making use of python2-nose. This is what is done
by Nixpkgs.

Is there anybody else who could not build beets before? Would you like
to test the patch?

> -- 
> Alex Griffin
> 
> 
> On Sat, Mar 26, 2016, at 06:41 AM, Ludovic Courtès wrote:
> > Leo Famulari <leo@famulari.name> skribis:
> > 
> > > Can you try building with '#:parallel-tests? #f', as shown in this link?
> > 
> > I was also going to suggest something along these lines.
> > 
> > Could you try building with with --rounds=4, say, on your machine?  (Or
> > --check if it’s already there.)
> > 
> > Thanks,
> > Ludo’.

[-- Attachment #2: 0001-gnu-beets-Run-tests-with-python-nose.patch --]
[-- Type: text/x-diff, Size: 1377 bytes --]

From ba2cb8403ab9340ab8a6da534e9db4cc3f2fbb84 Mon Sep 17 00:00:00 2001
From: Leo Famulari <leo@famulari.name>
Date: Sat, 26 Mar 2016 17:53:59 -0400
Subject: [PATCH] gnu: beets: Run tests with python-nose.

* gnu/packages/music.scm (nose)[native-inputs]: Add python-nose.
[arguments]: Replace 'check' and use python-nose.
---
 gnu/packages/music.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 89f49c6..48d6214 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1274,13 +1274,16 @@ websites such as Libre.fm.")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'set-HOME
-           (lambda _ (setenv "HOME" (string-append (getcwd) "/tmp")))))))
+           (lambda _ (setenv "HOME" (string-append (getcwd) "/tmp"))))
+         (replace 'check
+           (lambda _ (zero? (system* "nosetests" "-v")))))))
     (native-inputs
      `(("python2-beautifulsoup4" ,python2-beautifulsoup4)
        ("python2-flask" ,python2-flask)
        ("python2-setuptools" ,python2-setuptools)
        ("python2-mock" ,python2-mock)
        ("python2-mpd2" ,python2-mpd2)
+       ("python2-nose" ,python2-nose)
        ("python2-pathlib" ,python2-pathlib)
        ("python2-pyxdg" ,python2-pyxdg)
        ("python2-pyechonest" ,python2-pyechonest)
-- 
2.7.3