unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Alex Griffin <a@ajgrf.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 13/13] gnu: Add beets.
Date: Sun, 27 Mar 2016 17:36:19 -0400	[thread overview]
Message-ID: <20160327213619.GB29056@jasmine> (raw)
In-Reply-To: <1459004312.934516.560284258.4584E406@webmail.messagingengine.com>

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

On Sat, Mar 26, 2016 at 09:58:32AM -0500, Alex Griffin wrote:
> I tried building with --rounds=4 on my GuixSD machine, but it errored
> out after the first build with the same error. Then I tried building
> with --check on my Debian machine and it succeeded.
> 
> Last night on IRC we were discussing this more and I think Leo was going
> to try incorporating something from the nixos beets package, or else
> wait until the beets developers could help him.

On IRC, (the user who I think is) Alex said that they were able to build
beets with the attached patch.

All the patch does is invoke the tests with `nosetests -v` instead of
`python setup.py test`, making use of python2-nose. This is what is done
by Nixpkgs.

Is there anybody else who could not build beets before? Would you like
to test the patch?

> -- 
> Alex Griffin
> 
> 
> On Sat, Mar 26, 2016, at 06:41 AM, Ludovic Courtès wrote:
> > Leo Famulari <leo@famulari.name> skribis:
> > 
> > > Can you try building with '#:parallel-tests? #f', as shown in this link?
> > 
> > I was also going to suggest something along these lines.
> > 
> > Could you try building with with --rounds=4, say, on your machine?  (Or
> > --check if it’s already there.)
> > 
> > Thanks,
> > Ludo’.

[-- Attachment #2: 0001-gnu-beets-Run-tests-with-python-nose.patch --]
[-- Type: text/x-diff, Size: 1377 bytes --]

From ba2cb8403ab9340ab8a6da534e9db4cc3f2fbb84 Mon Sep 17 00:00:00 2001
From: Leo Famulari <leo@famulari.name>
Date: Sat, 26 Mar 2016 17:53:59 -0400
Subject: [PATCH] gnu: beets: Run tests with python-nose.

* gnu/packages/music.scm (nose)[native-inputs]: Add python-nose.
[arguments]: Replace 'check' and use python-nose.
---
 gnu/packages/music.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 89f49c6..48d6214 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1274,13 +1274,16 @@ websites such as Libre.fm.")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'set-HOME
-           (lambda _ (setenv "HOME" (string-append (getcwd) "/tmp")))))))
+           (lambda _ (setenv "HOME" (string-append (getcwd) "/tmp"))))
+         (replace 'check
+           (lambda _ (zero? (system* "nosetests" "-v")))))))
     (native-inputs
      `(("python2-beautifulsoup4" ,python2-beautifulsoup4)
        ("python2-flask" ,python2-flask)
        ("python2-setuptools" ,python2-setuptools)
        ("python2-mock" ,python2-mock)
        ("python2-mpd2" ,python2-mpd2)
+       ("python2-nose" ,python2-nose)
        ("python2-pathlib" ,python2-pathlib)
        ("python2-pyxdg" ,python2-pyxdg)
        ("python2-pyechonest" ,python2-pyechonest)
-- 
2.7.3


  reply	other threads:[~2016-03-27 21:36 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-04  1:26 [PATCH 00/13] Add beets and its dependencies Leo Famulari
2016-03-04  1:26 ` [PATCH 01/13] gnu: Add python-mutagen Leo Famulari
2016-03-04  1:26 ` [PATCH 02/13] gnu: Add python-munkres Leo Famulari
2016-03-04  1:26 ` [PATCH 03/13] gnu: Add python-musicbrainzngs Leo Famulari
2016-03-04  1:26 ` [PATCH 04/13] gnu: Add python-flask Leo Famulari
2016-03-04  1:26 ` [PATCH 05/13] gnu: Add python-pyechonest Leo Famulari
2016-03-04  1:26 ` [PATCH 06/13] gnu: Add python-pylast Leo Famulari
2016-03-04  1:26 ` [PATCH 07/13] gnu: Add python-responses Leo Famulari
2016-03-04  1:26 ` [PATCH 08/13] gnu: Add python2-pathlib Leo Famulari
2016-03-04  1:26 ` [PATCH 09/13] gnu: Add python-mpd2 Leo Famulari
2016-03-04  1:26 ` [PATCH 10/13] gnu: Add python-jellyfish Leo Famulari
2016-03-04  1:26 ` [PATCH 11/13] gnu: Add python2-unicodecsv Leo Famulari
2016-03-04  1:26 ` [PATCH 12/13] gnu: Add python-rarfile Leo Famulari
2016-03-04 12:42   ` Ricardo Wurmus
2016-03-04 21:29     ` Leo Famulari
2016-03-13 22:00       ` Leo Famulari
2016-03-17 21:31         ` Ricardo Wurmus
2016-03-17 21:59           ` Leo Famulari
2016-03-18  6:44             ` Efraim Flashner
2016-03-18 16:24               ` Leo Famulari
2016-03-04  1:26 ` [PATCH 13/13] gnu: Add beets Leo Famulari
2016-03-18 18:29   ` Leo Famulari
2016-03-18 20:42     ` Ludovic Courtès
2016-03-25 16:04     ` Mark H Weaver
2016-03-25 17:27       ` Leo Famulari
2016-03-25 23:37         ` Alex Griffin
2016-03-26  0:30           ` Leo Famulari
2016-03-26  0:40             ` Leo Famulari
2016-03-26 11:41             ` Ludovic Courtès
2016-03-26 14:58               ` Alex Griffin
2016-03-27 21:36                 ` Leo Famulari [this message]
2016-03-27 22:25                   ` Leo Famulari
2016-03-28 16:25                 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160327213619.GB29056@jasmine \
    --to=leo@famulari.name \
    --cc=a@ajgrf.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).