From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Improve ant-build-system.
Date: Thu, 24 Mar 2016 12:08:03 -0400
Message-ID: <20160324160803.GA28393@jasmine>
References: <idjh9fwq69t.fsf@bimsb-sys02.mdc-berlin.net>
	<20160324153341.GA27637@jasmine>
	<idjbn63rhrc.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51918)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aj7nn-0002JT-Sn
	for guix-devel@gnu.org; Thu, 24 Mar 2016 12:08:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aj7ni-0001Wc-O9
	for guix-devel@gnu.org; Thu, 24 Mar 2016 12:08:03 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33435)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aj7ni-0001WS-JJ
	for guix-devel@gnu.org; Thu, 24 Mar 2016 12:07:58 -0400
Content-Disposition: inline
In-Reply-To: <idjbn63rhrc.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

On Thu, Mar 24, 2016 at 04:57:11PM +0100, Ricardo Wurmus wrote:
> 
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Thu, Mar 24, 2016 at 03:50:38PM +0100, Ricardo Wurmus wrote:
> >> Hi Guix,
> >> 
> >> our ant-build-system currently throws away the jar manifest, because it
> >> was difficult to control its timestamp.  Without a manifest many jars
> >> cannot be used, though.  Oops!
> >> 
> >> The manifest and the directory it is in always get the current time,
> >> which is very annoying.  Since controlling the timestamp is not possible
> >> with “jar”, this patch repacks the jar archive with “zip”.  The only
> >> thing we need to take care of is to ensure that the manifest file
> >> appears first.
> >
> > So, the timestamp issue is avoided by using "zip"? Just curious, I would
> > want to block this change regardless.

I meant to write "wouldn't".

> 
> Correct.  “jar” doesn’t just create an archive, it also sets the
> timestamp of the manifest.  “zip” doesn’t care about manifest timestamps
> and will just take the files as they are.  Since we reset timestamps of
> all files in the archive this means that the manifest will have the same
> timestamp as any other file in the archive.  This makes the jar archive
> reproducible.

Cool, I'm glad we have this option!

> 
> ~~ Ricardo