From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 3/3] gnu: python-pyopenssl: Update to 16.0.0.
Date: Wed, 23 Mar 2016 12:05:24 -0400
Message-ID: <20160323160524.GC2063@jasmine>
References: <cover.1458697233.git.leo@famulari.name>
	<436ad112fd28bef4eee70eb517ad91aff82d3e99.1458697233.git.leo@famulari.name>
	<20160323071642.GC29680@debian-netbook>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54301)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ailHh-0000gR-Ha
	for guix-devel@gnu.org; Wed, 23 Mar 2016 12:05:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ailHc-00048g-GO
	for guix-devel@gnu.org; Wed, 23 Mar 2016 12:05:25 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36121)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ailHc-00048b-DF
	for guix-devel@gnu.org; Wed, 23 Mar 2016 12:05:20 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
	by mailout.nyi.internal (Postfix) with ESMTP id 2E924217AA
	for <guix-devel@gnu.org>; Wed, 23 Mar 2016 12:05:20 -0400 (EDT)
Content-Disposition: inline
In-Reply-To: <20160323071642.GC29680@debian-netbook>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

On Wed, Mar 23, 2016 at 09:16:42AM +0200, Efraim Flashner wrote:
> On Tue, Mar 22, 2016 at 09:46:12PM -0400, Leo Famulari wrote:
> > * gnu/packages/python.scm (python-pyopenssl, python2-pyopenssl): Update to
> > 16.0.0.
> > [arguments]: Remove field.

> > -    (arguments
> > -     `(#:phases
> > -       (modify-phases %standard-phases
> > -         (add-after 'unpack 'fix-tests
> > -          (lambda* (#:key inputs #:allow-other-keys)
> > -            (substitute* "OpenSSL/test/test_ssl.py"
> > -              (("client\\.connect\\(\\('verisign\\.com', 443\\)\\)")
> > -               "return True")
> > -              ;; FIXME: disable broken test
> > -              (("test_set_tmp_ecdh") "disabled__set_tmp_ecdh"))
> > -            (substitute* "OpenSSL/test/test_crypto.py"
> > -              (("command = b\"openssl \"")
> > -               (string-append "command = b\""
> > -                              (assoc-ref inputs "openssl")
> > -                              "/bin/openssl" " \""))
> > -              ;; FIXME: disable four broken tests
> > -              (("test_der")             "disabled__der")
> > -              (("test_digest")          "disabled__digest")
> > -              (("test_get_extension")   "disabled__get_extension")
> > -              (("test_extension_count") "disabled__extension_count"))
> > -            #t)))))
> >      (propagated-inputs
> >       `(("python-cryptography" ,python-cryptography)
> >         ("python-six" ,python-six)))
> > -- 
> > 2.7.3
> > 
> 
> its always nice to see work-around phases getting removed.

Indeed!