Re: [PATCH 3/3] gnu: python-pyopenssl: Update to 16.0.0.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 2631 bytes --]

On Tue, Mar 22, 2016 at 09:46:12PM -0400, Leo Famulari wrote:
> * gnu/packages/python.scm (python-pyopenssl, python2-pyopenssl): Update to
> 16.0.0.
> [arguments]: Remove field.
> ---
>  gnu/packages/python.scm | 25 ++-----------------------
>  1 file changed, 2 insertions(+), 23 deletions(-)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 571b26b..2238ae2 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -5848,7 +5848,7 @@ message digests and key derivation functions.")
>  (define-public python-pyopenssl
>    (package
>      (name "python-pyopenssl")
> -    (version "0.15.1")
> +    (version "16.0.0")
>      (source
>       (origin
>         (method url-fetch)
> @@ -5856,29 +5856,8 @@ message digests and key derivation functions.")
>                             "pyOpenSSL/pyOpenSSL-" version ".tar.gz"))
>         (sha256
>          (base32
> -         "0wnnq15rhj7fhdcd8ycwiw6r6g3w9f9lcy6cigg8226vsrq618ph"))))
> +         "0zfijaxlq4vgi6jz0d4i5xq9ygqnyps6br7lmigjhqnh8gp10g9n"))))
>      (build-system python-build-system)
> -    (arguments
> -     `(#:phases
> -       (modify-phases %standard-phases
> -         (add-after 'unpack 'fix-tests
> -          (lambda* (#:key inputs #:allow-other-keys)
> -            (substitute* "OpenSSL/test/test_ssl.py"
> -              (("client\\.connect\\(\\('verisign\\.com', 443\\)\\)")
> -               "return True")
> -              ;; FIXME: disable broken test
> -              (("test_set_tmp_ecdh") "disabled__set_tmp_ecdh"))
> -            (substitute* "OpenSSL/test/test_crypto.py"
> -              (("command = b\"openssl \"")
> -               (string-append "command = b\""
> -                              (assoc-ref inputs "openssl")
> -                              "/bin/openssl" " \""))
> -              ;; FIXME: disable four broken tests
> -              (("test_der")             "disabled__der")
> -              (("test_digest")          "disabled__digest")
> -              (("test_get_extension")   "disabled__get_extension")
> -              (("test_extension_count") "disabled__extension_count"))
> -            #t)))))
>      (propagated-inputs
>       `(("python-cryptography" ,python-cryptography)
>         ("python-six" ,python-six)))
> -- 
> 2.7.3
> 

its always nice to see work-around phases getting removed.

LGTM!

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]