From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH] Add stellarium Date: Tue, 22 Mar 2016 23:45:08 -0500 Message-ID: <20160322234508.7b5eba4b@openmailbox.org> References: <20160322214844.458cb0bd@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiafo-0003td-H5 for guix-devel@gnu.org; Wed, 23 Mar 2016 00:45:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiafl-0006IG-9R for guix-devel@gnu.org; Wed, 23 Mar 2016 00:45:36 -0400 Received: from mail.openmailbox.org ([62.4.1.34]:50400 helo=mail2.openmailbox.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiafk-0006Ht-Vh for guix-devel@gnu.org; Wed, 23 Mar 2016 00:45:33 -0400 In-Reply-To: <20160322214844.458cb0bd@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Danny Milosavljevic Cc: guix-devel@gnu.org On Tue, 22 Mar 2016 21:48:44 +0100 Danny Milosavljevic wrote: > Hi, > > this adds a regular file gnu/package/astronomy.scm and the package "stellarium" in it. I'm not knowledgable about the number of astronomy packages out there, but it might make sense to add this to a more general "education" modules instead. > > diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm > new file mode 100644 > index 0000000..ac02344 > --- /dev/null > +++ b/gnu/packages/astronomy.scm > @@ -0,0 +1,58 @@ > +;;; GNU Guix --- Functional package management for GNU Remember to add a copyright statement for yourself in the header. See other source files. > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages astronomy) > + #:use-module (ice-9 regex) > + #:use-module (gnu packages) > + #:use-module (gnu packages qt) > + #:use-module (gnu packages compression) > + #:use-module (gnu packages gettext) > + #:use-module (gnu packages perl) > + #:use-module ((guix licenses) #:prefix license:) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix svn-download) > + #:use-module (guix utils) > + #:use-module (guix build-system gnu) > + #:use-module (guix build-system cmake) > + #:use-module (srfi srfi-1)) > + > +(define-public stellarium > + (package > + (name "stellarium") > + (version "0.14.2") > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://sourceforge/stellarium/" > + "Stellarium-sources/" > + version "/stellarium-" version ".tar.gz")) > + (sha256 (base32 > + "1xxil0rv61zc08znfv83cpsc47y1gjl2f3njhz0pn5zd8jpaa15a")))) > + (build-system cmake-build-system) > + (synopsis "3D Sky Viewer") > + (description "Astronomy Sky Catalogue.") The description here needs to be at least a full sentence. See the "Synopses and Descriptions" section in the manual. > + (license license:gpl2+) > + (home-page "http://www.stellarium.org/") > + (arguments `(#:tests? #f)) Please also leave a comment explaining why tests are disabled. > + (inputs > + `(("qt" ,qt) > + ("zlib" ,zlib) > + ; qt5-script, qt5-serialport > + ("gettext" ,gnu-gettext))) > + ;; perl: for pod2man > + (native-inputs > + `(("qt" ,qt) Is there a reason qt needs to be a native input in addition to a regular input? If so, include a comment explaining why. > + ("perl" ,perl))))) I prefer the convention used elsewhere of listing the inputs immediately after the "build-syste" field. Could you send an updated patch? Thanks, `~Eric