* [PATCH] Add stellarium
@ 2016-03-22 20:48 Danny Milosavljevic
2016-03-23 4:45 ` Eric Bavier
2016-07-27 16:30 ` Danny Milosavljevic
0 siblings, 2 replies; 4+ messages in thread
From: Danny Milosavljevic @ 2016-03-22 20:48 UTC (permalink / raw)
To: guix-devel
Hi,
this adds a regular file gnu/package/astronomy.scm and the package "stellarium" in it.
diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
new file mode 100644
index 0000000..ac02344
--- /dev/null
+++ b/gnu/packages/astronomy.scm
@@ -0,0 +1,58 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages astronomy)
+ #:use-module (ice-9 regex)
+ #:use-module (gnu packages)
+ #:use-module (gnu packages qt)
+ #:use-module (gnu packages compression)
+ #:use-module (gnu packages gettext)
+ #:use-module (gnu packages perl)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix packages)
+ #:use-module (guix download)
+ #:use-module (guix svn-download)
+ #:use-module (guix utils)
+ #:use-module (guix build-system gnu)
+ #:use-module (guix build-system cmake)
+ #:use-module (srfi srfi-1))
+
+(define-public stellarium
+ (package
+ (name "stellarium")
+ (version "0.14.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://sourceforge/stellarium/"
+ "Stellarium-sources/"
+ version "/stellarium-" version ".tar.gz"))
+ (sha256 (base32
+ "1xxil0rv61zc08znfv83cpsc47y1gjl2f3njhz0pn5zd8jpaa15a"))))
+ (build-system cmake-build-system)
+ (synopsis "3D Sky Viewer")
+ (description "Astronomy Sky Catalogue.")
+ (license license:gpl2+)
+ (home-page "http://www.stellarium.org/")
+ (arguments `(#:tests? #f))
+ (inputs
+ `(("qt" ,qt)
+ ("zlib" ,zlib)
+ ; qt5-script, qt5-serialport
+ ("gettext" ,gnu-gettext)))
+ ;; perl: for pod2man
+ (native-inputs
+ `(("qt" ,qt)
+ ("perl" ,perl)))))
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Add stellarium
2016-03-22 20:48 [PATCH] Add stellarium Danny Milosavljevic
@ 2016-03-23 4:45 ` Eric Bavier
2016-03-23 6:21 ` Danny Milosavljevic
2016-07-27 16:30 ` Danny Milosavljevic
1 sibling, 1 reply; 4+ messages in thread
From: Eric Bavier @ 2016-03-23 4:45 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: guix-devel
On Tue, 22 Mar 2016 21:48:44 +0100
Danny Milosavljevic <dannym@scratchpost.org> wrote:
> Hi,
>
> this adds a regular file gnu/package/astronomy.scm and the package "stellarium" in it.
I'm not knowledgable about the number of astronomy packages out there,
but it might make sense to add this to a more general "education"
modules instead.
>
> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> new file mode 100644
> index 0000000..ac02344
> --- /dev/null
> +++ b/gnu/packages/astronomy.scm
> @@ -0,0 +1,58 @@
> +;;; GNU Guix --- Functional package management for GNU
Remember to add a copyright statement for yourself in the header. See
other source files.
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages astronomy)
> + #:use-module (ice-9 regex)
> + #:use-module (gnu packages)
> + #:use-module (gnu packages qt)
> + #:use-module (gnu packages compression)
> + #:use-module (gnu packages gettext)
> + #:use-module (gnu packages perl)
> + #:use-module ((guix licenses) #:prefix license:)
> + #:use-module (guix packages)
> + #:use-module (guix download)
> + #:use-module (guix svn-download)
> + #:use-module (guix utils)
> + #:use-module (guix build-system gnu)
> + #:use-module (guix build-system cmake)
> + #:use-module (srfi srfi-1))
> +
> +(define-public stellarium
> + (package
> + (name "stellarium")
> + (version "0.14.2")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://sourceforge/stellarium/"
> + "Stellarium-sources/"
> + version "/stellarium-" version ".tar.gz"))
> + (sha256 (base32
> + "1xxil0rv61zc08znfv83cpsc47y1gjl2f3njhz0pn5zd8jpaa15a"))))
> + (build-system cmake-build-system)
> + (synopsis "3D Sky Viewer")
> + (description "Astronomy Sky Catalogue.")
The description here needs to be at least a full sentence. See the
"Synopses and Descriptions" section in the manual.
> + (license license:gpl2+)
> + (home-page "http://www.stellarium.org/")
> + (arguments `(#:tests? #f))
Please also leave a comment explaining why tests are disabled.
> + (inputs
> + `(("qt" ,qt)
> + ("zlib" ,zlib)
> + ; qt5-script, qt5-serialport
> + ("gettext" ,gnu-gettext)))
> + ;; perl: for pod2man
> + (native-inputs
> + `(("qt" ,qt)
Is there a reason qt needs to be a native input in addition to a
regular input? If so, include a comment explaining why.
> + ("perl" ,perl)))))
I prefer the convention used elsewhere of listing the inputs
immediately after the "build-syste" field.
Could you send an updated patch? Thanks,
`~Eric
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add stellarium
2016-03-23 4:45 ` Eric Bavier
@ 2016-03-23 6:21 ` Danny Milosavljevic
0 siblings, 0 replies; 4+ messages in thread
From: Danny Milosavljevic @ 2016-03-23 6:21 UTC (permalink / raw)
To: Eric Bavier; +Cc: guix-devel
On Tue, 22 Mar 2016 23:45:08 -0500
Eric Bavier <ericbavier@openmailbox.org> wrote:
> Is there a reason qt needs to be a native input in addition to a
> regular input? If so, include a comment explaining why.
Not sure. I thought that when cross compiling we would need
(1) Qt-MOC to compile their C++ language extension to C++, at compile time
(2) Qt of the target architecture, at runtime
Is that not so?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add stellarium
2016-03-22 20:48 [PATCH] Add stellarium Danny Milosavljevic
2016-03-23 4:45 ` Eric Bavier
@ 2016-07-27 16:30 ` Danny Milosavljevic
1 sibling, 0 replies; 4+ messages in thread
From: Danny Milosavljevic @ 2016-07-27 16:30 UTC (permalink / raw)
To: guix-devel
Obsolete, replaced by "[PATCH v2] gnu: Add stellarium."
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-27 16:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-22 20:48 [PATCH] Add stellarium Danny Milosavljevic
2016-03-23 4:45 ` Eric Bavier
2016-03-23 6:21 ` Danny Milosavljevic
2016-07-27 16:30 ` Danny Milosavljevic
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).