From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 5/6] gnu: Add borg.
Date: Mon, 21 Mar 2016 17:31:15 -0400
Message-ID: <20160321213115.GA2717@jasmine>
References: <cover.1457998381.git.leo@famulari.name>
	<14fe75ec9c8b651be6a5240dd5444e558615e1e1.1457998381.git.leo@famulari.name>
	<878u1k2jik.fsf@gmail.com> <20160315091845.GA9602@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38879)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ai7Pz-0000tL-Tm
	for guix-devel@gnu.org; Mon, 21 Mar 2016 17:31:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ai7Pw-0006EI-Mk
	for guix-devel@gnu.org; Mon, 21 Mar 2016 17:31:19 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33616)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ai7Pw-0006EE-I2
	for guix-devel@gnu.org; Mon, 21 Mar 2016 17:31:16 -0400
Content-Disposition: inline
In-Reply-To: <20160315091845.GA9602@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

On Tue, Mar 15, 2016 at 05:18:45AM -0400, Leo Famulari wrote:
> On Tue, Mar 15, 2016 at 12:11:15PM +0300, Alex Kost wrote:
> > Leo Famulari (2016-03-15 02:34 +0300) wrote:
> > > +       (modify-phases %standard-phases
> > > +         (add-before 'build 'set-openssl-prefix
> > > +           (lambda* (#:key inputs #:allow-other-keys)
> > > +             (setenv "BORG_OPENSSL_PREFIX" (assoc-ref inputs "openssl"))
> > > +             #t))
> > > +         (add-before 'build 'set-lz4-prefix
> > > +           (lambda* (#:key inputs #:allow-other-keys)
> > > +             (setenv "BORG_LZ4_PREFIX" (assoc-ref inputs "lz4"))
> > > +             #t))
> > 
> > Would it be better to make a single 'set-env' phase instead?  Or better
> > yet, are these '..._PREFIX' variables used for make command?  If so,
> > they should be specified in #:make-flags argument.
> 
> Thank you, that makes the recipe shorter and clearer.

I didn't test the change before replying ;)

There is no #:make-flags for the python-build-system, so I have used a
single set-env phase instead.