From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Add ustr.
Date: Mon, 21 Mar 2016 11:24:57 -0400
Message-ID: <20160321152457.GB25170@jasmine>
References: <idjshzpti8i.fsf@bimsb-sys02.mdc-berlin.net>
	<20160318184056.GA9682@jasmine>
	<idjpounsx4r.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35616)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ai1hU-0002cS-7l
	for guix-devel@gnu.org; Mon, 21 Mar 2016 11:25:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ai1hR-0001hJ-0Z
	for guix-devel@gnu.org; Mon, 21 Mar 2016 11:25:00 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36475)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ai1hQ-0001hC-SA
	for guix-devel@gnu.org; Mon, 21 Mar 2016 11:24:56 -0400
Content-Disposition: inline
In-Reply-To: <idjpounsx4r.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

On Mon, Mar 21, 2016 at 03:50:44PM +0100, Ricardo Wurmus wrote:
> 
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Thu, Mar 17, 2016 at 01:13:33PM +0100, Ricardo Wurmus wrote:
> >> * gnu/packages/textutils.scm (ustr): New variable.
> >
> > [...]
> >
> >> +              (uri (string-append "http://www.and.org/ustr/" version
> >> +                                  "/ustr-" version ".tar.bz2"))
> 
> [...]
> 
> > It looks like this directory only contains the current version of the
> > code, but I can't find an archive of old releases. How about mentioning
> > this in a comment, and (maybe) asking and.org to provide an archive?
> 
> Actually, there are older versions as well.  Version 1.0.2, for example,
> is at
> 
>     http://www.and.org/ustr/1.0.2/ustr-1.0.2.tar.bz2

Ah, I see now!

> 
> >> +    (build-system gnu-build-system)
> >> +    (arguments
> >> +     `(#:make-flags
> >> +       (list "CC=gcc"
> >> +             "HIDE="
> >
> > I read the Makefile's comment about this. ;)
> 
> I guess we don’t qualify as “all sane people” :)
> 
> >> +             "LDCONFIG=echo"
> >
> > Can you explain this one in a comment?
> 
> Will do.
> 
> >> +             (string-append "prefix=" (assoc-ref %outputs "out"))
> >> +             "all-shared")
> >
> > [...]
> >
> >> +    ;; Quoted from the home page: "The License for the code is MIT, new-BSD,
> >> +    ;; LGPL, etc. ... if you need another license to help compatibility, just
> >> +    ;; ask for it.  It's basically public domain, without all the legal
> >> +    ;; problems for everyone that trying to make something public domain
> >> +    ;; entails."
> >> +    (license license:public-domain)))
> >
> > Sounds good to me. Hopefully there are no objections from the legal
> > experts!
> 
> Thanks for taking the time to review!  I’ll push this after adding the
> comment.

Okay!

> 
> ~~ Ricardo