[PATCH] Add syslog.scm and rsyslog.

[PATCH] Add syslog.scm and rsyslog.

[Danny Milosavljevic]

Hi,

this adds gnu/packages/syslog.scm and rsyslog.

If someone knowledgeable about which license text is which license can check the FIXMEs that would be nice.

That said, it seems inetutils also contains a syslogd (it also auto-starts; I didn't see it before) - so not sure how useful having another syslog is now.

Regards,
   Danny

---
 gnu/packages/syslog.scm | 110 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 110 insertions(+)
 create mode 100644 gnu/packages/syslog.scm

diff --git a/gnu/packages/syslog.scm b/gnu/packages/syslog.scm
new file mode 100644
index 0000000..daaf6b1
--- /dev/null
+++ b/gnu/packages/syslog.scm
@@ -0,0 +1,110 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
+;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages syslog)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages pkg-config)
+)
+
+(define-public libestr
+  (package
+    (name "libestr")
+    (version "0.1.10")
+    (source (origin
+            (method url-fetch)
+            (uri (string-append "http://libestr.adiscon.com/files/download/libestr-" version ".tar.gz"))
+            (sha256
+             (base32
+              "0g3hmh3wxgjbn5g6cgy2l0ja806jd0ayp22bahcds3kmdq95wrdx"))))
+    (build-system gnu-build-system)
+    (home-page "http://libestr.adiscon.com/")
+    (synopsis "rsyslog essential string handling")
+    (description "rsyslog essential string handling")
+    (license license:gpl2+))) ; FIXME actually gpl2.1+
+
+(define-public libfastjson
+  (package
+    (name "libfastjson")
+    (version "0.99.2")
+    (source (origin
+            (method url-fetch)
+            (uri (string-append "http://download.rsyslog.com/libfastjson/libfastjson-" version ".tar.gz"))
+            (sha256
+             (base32
+              "1zcd8nzwh8br79n34mka4m08v6vdfhfdid1p9w0q2fi4apa57w3g"))))
+    (build-system gnu-build-system)
+    (home-page "http://www.rsyslog.com/")
+    (synopsis "rsyslog json-c fork")
+    (description "rsyslog json-c fork")
+    (license license:gpl2+))) ; FIXME actually MIT. Which one?
+
+(define-public liblogging
+  (package
+    (name "liblogging")
+    (version "1.0.5")
+    (source (origin
+            (method url-fetch)
+            (uri (string-append "http://download.rsyslog.com/liblogging/liblogging-" version ".tar.gz"))
+            (sha256
+             (base32
+              "02w94j344q0ywlj4mdf9fnzwggdsn3j1yn43sdlsddvr29lw239i"))))
+    (build-system gnu-build-system)
+    (home-page "http://www.rsyslog.com/")
+    (synopsis "rsyslog logging library")
+    (description "rsyslog logging library")
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (arguments `(#:configure-flags '("--disable-journal" ; to avoid libsystemd-journal
+)))
+    (license license:bsd-2))) ; FIXME https://github.com/rsyslog/liblogging/commit/78305e36938803e8a6c0a1be461ad7817d43563d
+
+(define-public rsyslog
+  (package
+    (name "rsyslog")
+    (version "8.17.0")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "http://www.rsyslog.com/files/download/rsyslog/rsyslog-" version ".tar.gz"))
+      (sha256
+       (base32
+        "1fazpbllr3wk8aw41zk7b6iirds4h8j3im080nf8my2cjssij7pc"))))
+    (build-system gnu-build-system)
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (inputs `(("libestr"      ,libestr)
+              ("libfastjson"  ,libfastjson)
+              ("zlib"         ,zlib)
+              ("util-linux"   ,util-linux)
+              ("libgcrypt" ,libgcrypt)
+              ("liblogging" ,liblogging)))
+; TODO enable rfc3195 support
+; TODO liblogging-stdlog
+    (home-page "http://www.rsyslog.com/")
+    (synopsis "System Logger")
+    (description "rsyslog is the rocket-fast system for log processing.")
+; note: can disable uuid-dev (maybe not Linux-specific then)
+; note: can enable lots of things
+    (license license:gpl3))) ; or ASL 2.0
+
-- 
2.7.3

Re: [PATCH] Add syslog.scm and rsyslog.

[Leo Famulari]

On Sat, Mar 19, 2016 at 06:25:24PM +0100, Danny Milosavljevic wrote:
> Hi,
> 
> this adds gnu/packages/syslog.scm and rsyslog.

Hi, thanks for this, sorry for the delayed review!

> If someone knowledgeable about which license text is which license can check the FIXMEs that would be nice.

My approach to checking licenses is to do a web search for some phrase
from the license, and then check the package's license text against the
results of the search.

Also, these are some good resources:
https://www.gnu.org/licenses/license-list
www.gnu.org/licenses/license-list.html

> 
> That said, it seems inetutils also contains a syslogd (it also auto-starts; I didn't see it before) - so not sure how useful having another syslog is now.

If rsyslog is a different program, then it's useful to someone!

> ---
>  gnu/packages/syslog.scm | 110 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 110 insertions(+)
>  create mode 100644 gnu/packages/syslog.scm

For your revisions, please submit each package as its own patch. You can
read `git log` to learn the conventions for commit messages.

Also, please remember to run `./pre-inst-env guix lint` on each
package. Most of the changes that need to made to these packages will be
described by `guix lint`.

[...]

> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
> +;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>

Don't forget to add a copyright line for yourself.

> +(define-public libfastjson

[...]

> +    (license license:gpl2+))) ; FIXME actually MIT. Which one?

In the links I shared above, refer to the Expat and X11 licenses to see
which "MIT" license this is.

> +(define-public liblogging

[...]

> +    (arguments `(#:configure-flags '("--disable-journal" ; to avoid libsystemd-journal
> +)))

If you leave the journal support enabled, does the program break when
journald is absent? Users on systemd-based systems may want to use
liblogging :)

> +(define-public rsyslog

[...]

> +    (inputs `(("libestr"      ,libestr)
> +              ("libfastjson"  ,libfastjson)
> +              ("zlib"         ,zlib)
> +              ("util-linux"   ,util-linux)

Since util-linux is a "grab bag" of unrelated programs, I like to say in
what it's being used for. There are some examples of this in
gnu/packages.

Can you submit a revised patch set?