From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add bash-tap. Date: Fri, 18 Mar 2016 19:53:39 +0100 Message-ID: <20160318185339.GA20746@solar> References: <8760wlrst0.fsf@gnu.org> <20160318184342.GB9682@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agzWv-0001f8-BT for guix-devel@gnu.org; Fri, 18 Mar 2016 14:53:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agzWs-0004in-3d for guix-devel@gnu.org; Fri, 18 Mar 2016 14:53:49 -0400 Received: from mailrelay1.public.one.com ([91.198.169.124]:39457) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agzWr-0004iQ-PU for guix-devel@gnu.org; Fri, 18 Mar 2016 14:53:46 -0400 Content-Disposition: inline In-Reply-To: <20160318184342.GB9682@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org On Fri, Mar 18, 2016 at 02:43:42PM -0400, Leo Famulari wrote: > Can someone with more experience take a look and apply the patch if it's > okay? I had a look (without having much experience with the trivial build system), and it looks mostly clean. However, the package installs three bash scripts that start with "#!/bin/bash". This will not work on GuixSD, where only /bin/sh exists. It should be patched by adding bash as an input and substituting. Alternatively, you could use the gnu-build-system, delete most of the phases, set #:tests? to #f and add a custom install phase; then the patch-shebangs phase will do its magic. Andreas