From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 12/13] gnu: Add python-rarfile.
Date: Thu, 17 Mar 2016 17:59:04 -0400
Message-ID: <20160317215904.GA7724@jasmine>
References: <cover.1457054741.git.leo@famulari.name>
	<8c8f5af9405151b57f1db84e194a15723751a9f1.1457054741.git.leo@famulari.name>
	<idjd1raxvmk.fsf@bimsb-sys02.mdc-berlin.net>
	<20160304212940.GA463@jasmine> <20160313220026.GA29732@jasmine>
	<878u1g4wqq.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1agfwm-0005d7-Jo
	for guix-devel@gnu.org; Thu, 17 Mar 2016 17:59:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1agfwh-0002ko-Jw
	for guix-devel@gnu.org; Thu, 17 Mar 2016 17:59:12 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43312)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1agfwh-0002kk-FX
	for guix-devel@gnu.org; Thu, 17 Mar 2016 17:59:07 -0400
Content-Disposition: inline
In-Reply-To: <878u1g4wqq.fsf@elephly.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

On Thu, Mar 17, 2016 at 10:31:41PM +0100, Ricardo Wurmus wrote:
> 
> Leo Famulari <leo@famulari.name> writes:
> 
> >> > Does this actually work?  I assumed that our “libarchive” package has no
> >> > support for RAR archives.
> >> 
> >> I don't know. The libarchive documentation in
> >> 'share/man/man5/libarchive-formats.5.gz' does list RAR as a supported
> >> format.
> >
> > Also, libarchive's 'include/archive.h' defines ARCHIVE_FORMAT_RAR and
> > declares archive_read_support_format_rar().
> >
> > I don't have any .rar archives to test with, and I haven't seen one in
> > years.
> >
> > [...]
> >
> >> So, what should I do? Patch "rarfile" out of setup.py or package
> >> python-rarfile?
> >
> > Any feedback? I'd rather package python-rarfile.
> 
> I was just curious.  We can revisit this later when someone want to
> actually use python-rarfile to read rar files :)
> 
> I have no objections to this patch.

Okay, I will take another look at this patch series and probably push it
later today.

> 
> ~~ Ricardo
>