Re: [PATCH v2] gnu: Add idle3-tools.

[Leo Famulari <leo@famulari.name>]

On Wed, Mar 16, 2016 at 05:02:24AM +0100, Tobias Geerinckx-Rice wrote:
> Leo,
> 
> I just realised that I forgot to add you in CC. I'm still learning the
> finer points of git send-email...
> 
> (Of course, if you had already seen the updated patch, cheerily ignore
> this message.)

I'm sorry, my inbox grew too large!

I standardized the indentation of modify-phases, set DESTDIR in the
#:make-flags to make the installation succeed, and I also removed a
'/usr' from the path to the manpage:

+       (modify-phases %standard-phases
+         (delete 'configure))
+       #:make-flags (list "CC=gcc"
+                          (string-append "manprefix=")
+                          (string-append "DESTDIR="
+                                         (assoc-ref %outputs "out")))))

Did it work for you without setting DESTDIR?

Anyways, pushed as 8e14e059c40c!

Thanks for packaging this, and sorry again for the delay!

> 
> Kind regards,
> 
> T G-R
> 
> On 08/03/2016, Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com> wrote:
> > * gnu/packages/disk.scm (idle3-tools): New variable.
> > ---
> >  gnu/packages/disk.scm | 28 ++++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >
> > diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
> > index b9240a3..37c7bf5 100644
> > --- a/gnu/packages/disk.scm
> > +++ b/gnu/packages/disk.scm
> > @@ -171,3 +171,31 @@ transport), SCSI and ATAPI tape drives, and SCSI
> > enclosures.  This utility can
> >  also send commands associated with starting and stopping the media,
> > loading
> >  and unloading removable media and some other housekeeping functions.")
> >      (license bsd-3)))
> > +
> > +(define-public idle3-tools
> > +  (package
> > +    (name "idle3-tools")
> > +    (version "0.9.1")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (string-append "mirror://sourceforge/idle3-tools/idle3-tools-"
> > +                           version ".tgz"))
> > +       (sha256
> > +        (base32
> > +         "00ia7xq9yldxyl9gz0mr4xa568nav14p0fnv82f2rbbkg060cy4p"))))
> > +    (build-system gnu-build-system)
> > +    (arguments
> > +     `(#:tests? #f ;no test suite
> > +       #:phases (modify-phases %standard-phases
> > +         (delete 'configure))
> > +       #:make-flags '("CC=gcc")))
> > +    (home-page "http://idle3-tools.sourceforge.net")
> > +    (synopsis "Change or disable Western Digital hard drives' Idle3
> > timer")
> > +    (description
> > +     "Idle3-tools provides a utility to get, set, or disable the Idle3
> > timer
> > +present in many Western Digital hard drives.  This timer is part of the
> > +\"IntelliPark\" feature that stops the disk when not in use.
> > Unfortunately,
> > +the default timer setting is not well suited to Linux or other *nix
> > systems,
> > +and can dramatically shorten the lifespan of the drive if left
> > unchecked.")
> > +    (license gpl3+)))
> > --
> > 2.7.0
> >
> >