From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 12/13] gnu: Add python-rarfile. Date: Sun, 13 Mar 2016 18:00:26 -0400 Message-ID: <20160313220026.GA29732@jasmine> References: <8c8f5af9405151b57f1db84e194a15723751a9f1.1457054741.git.leo@famulari.name> <20160304212940.GA463@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afE3s-0001UH-CF for guix-devel@gnu.org; Sun, 13 Mar 2016 18:00:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afE3p-0001rY-5Q for guix-devel@gnu.org; Sun, 13 Mar 2016 18:00:32 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:49902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afE3o-0001rG-Ij for guix-devel@gnu.org; Sun, 13 Mar 2016 18:00:29 -0400 Content-Disposition: inline In-Reply-To: <20160304212940.GA463@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org On Fri, Mar 04, 2016 at 04:29:40PM -0500, Leo Famulari wrote: > On Fri, Mar 04, 2016 at 01:42:11PM +0100, Ricardo Wurmus wrote: > > > > Leo Famulari writes: > > > > > * gnu/packages/python.scm (python-rarfile, python2-rarfile): New > > > variables. > > > * gnu/packages/patches/python-rarfile-fix-tests.patch: New file. > > > * gnu-system.am (dist_patch_DATA): Add it. > > > --- > > > > [...] > > > > > + (propagated-inputs > > > + `(("libarchive" ,libarchive))) > > > + (home-page "https://github.com/markokr/rarfile") > > > + (synopsis "RAR archive reader for Python") > > > + (description "This is Python module for RAR archive reading. The interface > > > +is made as zipfile like as possible.") > > > + (license isc))) > > > > Does this actually work? I assumed that our “libarchive” package has no > > support for RAR archives. > > I don't know. The libarchive documentation in > 'share/man/man5/libarchive-formats.5.gz' does list RAR as a supported > format. Also, libarchive's 'include/archive.h' defines ARCHIVE_FORMAT_RAR and declares archive_read_support_format_rar(). I don't have any .rar archives to test with, and I haven't seen one in years. [...] > So, what should I do? Patch "rarfile" out of setup.py or package > python-rarfile? Any feedback? I'd rather package python-rarfile.