From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jookia <166291@gmail.com>
Subject: Re: [RFCv4] install: Create a GC root during install-grub.
Date: Sat, 12 Mar 2016 03:23:27 +1100
Message-ID: <20160311162327.GA28593@novena-choice-citizen.lan>
References: <56d7a6b8.8391700a.87f3c.ffffa7fe@mx.google.com>
	<56e2689e.890bc30a.12110.3cc0@mx.google.com>
	<878u1pyss9.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55542)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <166291@gmail.com>) id 1aeQBj-0003qf-8L
	for guix-devel@gnu.org; Fri, 11 Mar 2016 11:45:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <166291@gmail.com>) id 1aeQBf-0006fk-90
	for guix-devel@gnu.org; Fri, 11 Mar 2016 11:45:19 -0500
Content-Disposition: inline
In-Reply-To: <878u1pyss9.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Fri, Mar 11, 2016 at 03:48:38PM +0100, Ludovic Courtès wrote:
> Jookia <166291@gmail.com> skribis:
> 
> > While previously creating a GC root for GRUB's resources was the caller's
> > responsibility, it's much less repetitive to put it in install-grub now that
> > it's wrapped by error handling. This also means we can replace the install-grub*
> > function with a small definition inside perform-action named 'install-boot'.
> >
> > * gnu/build/install.scm (install-grub): Make a GC root for grub.cfg on success.
> >   (register-grub.cfg-root): Remove function, install-grub does this now.
> > * gnu/system/vm.scm (qemu-image): Don't explicitly make a GC root.
> > * guix/scripts/system.scm (install-grub*): Move useful parts to perform-action.
> >   (perform-action): Use inline definition install-boot to install GRUB.
> 
> Is it different from v1 to v3?
> 
> I’m asking because I feel it might be difficult for me to find out what
> the right version is when I start reviewing these.  :-)
> 
> Ludo’.

Yes, apologies since I'm not exactly sure how to add text that would be taken
out in final patches. v2 fixes an issue with reconfigure breaking since it
assumed there was always a target (not true), I can't remember what v3 fixed, v4
fixed v2's fix since I used the wrong variable name. Perhaps I should write
diffs to patches assuming all the patches are in a single directory?

Jookia.