From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: Add nethogs Date: Thu, 10 Mar 2016 16:41:36 -0500 Message-ID: <20160310214136.GA9678@jasmine> References: <87oaameckb.fsf@gmail.com> <87lh5qeak8.fsf@gmail.com> <87k2lae8xz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae8Kw-0006Mc-BJ for guix-devel@gnu.org; Thu, 10 Mar 2016 16:41:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae8Kr-0003eN-Ap for guix-devel@gnu.org; Thu, 10 Mar 2016 16:41:38 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:41746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae8Kr-0003eJ-6i for guix-devel@gnu.org; Thu, 10 Mar 2016 16:41:33 -0500 Content-Disposition: inline In-Reply-To: <87k2lae8xz.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Raimon Grau Cc: guix-devel@gnu.org On Thu, Mar 10, 2016 at 01:52:56PM +0000, Raimon Grau wrote: > > Raimon Grau writes: > > > I ran lint on it (forgot to do it previously), and now it complies with > > everything but "the source file name should contain the package name", > > although afaict it does contain it. I'll try to investigate more on that > > but that's the 'more correct version'. > > Apparently it's a warning that has to be there because indeed, the file > name doesn't contain the package name but only a version. GitHub's generated tarballs are almost always named something like v0.8.1.tar.gz. They don't include the name of the project itself (or the package). If you grep for 'file-name' in gnu/packages, you'll find some examples of how to name the output file. Also, the patch does not apply to current HEAD of master (ff22f01d67). I see in your patch the following context that I can't find in the master branch. Did you generate the patch on top of another local patch? > @@ -209,3 +210,38 @@ bandwidth usage in real time. It visualizes the in- and outgoing traffic using > two graphs and provides additional info like total amount of transfered data > and min/max network usage.") > (license license:gpl2))) > + > +(define-public nethogs > + (package [...] Can you send an updated patch?