unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Raimon Grau <raimonster@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Add nethogs
Date: Thu, 10 Mar 2016 16:41:36 -0500	[thread overview]
Message-ID: <20160310214136.GA9678@jasmine> (raw)
In-Reply-To: <87k2lae8xz.fsf@gmail.com>

On Thu, Mar 10, 2016 at 01:52:56PM +0000, Raimon Grau wrote:
> 
> Raimon Grau writes:
> 
> > I ran lint on it (forgot to do it previously), and now it complies with
> > everything but "the source file name should contain the package name",
> > although afaict it does contain it. I'll try to investigate more on that
> > but that's the 'more correct version'.
> 
> Apparently it's a warning that has to be there because indeed, the file
> name doesn't contain the package name but only a version.

GitHub's generated tarballs are almost always named something like
v0.8.1.tar.gz. They don't include the name of the project itself (or the
package).

If you grep for 'file-name' in gnu/packages, you'll find some examples
of how to name the output file.

Also, the patch does not apply to current HEAD of master (ff22f01d67). I
see in your patch the following context that I can't find in the master
branch. Did you generate the patch on top of another local patch?

> @@ -209,3 +210,38 @@ bandwidth usage in real time.  It visualizes the in- and outgoing traffic using
>  two graphs and provides additional info like total amount of transfered data
>  and min/max network usage.")
>      (license license:gpl2)))
> +
> +(define-public nethogs
> +  (package

[...]

Can you send an updated patch?

      reply	other threads:[~2016-03-10 21:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10 12:34 Add nethogs Raimon Grau
2016-03-10 13:17 ` Raimon Grau
2016-03-10 13:52   ` Raimon Grau
2016-03-10 21:41     ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160310214136.GA9678@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=raimonster@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).