unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: simple-scan: Update to 3.19.91.
Date: Tue, 8 Mar 2016 19:05:06 -0500	[thread overview]
Message-ID: <20160309000506.GD24107@jasmine> (raw)
In-Reply-To: <CAKFHe2QNcWoCb5rt+YhDr=AKY3UU7037Q6fDBnVQLTa0xGD=9w@mail.gmail.com>

On Wed, Mar 09, 2016 at 12:43:52AM +0100, Tobias Geerinckx-Rice wrote:
> Hullo Leo,
> 
> On 09/03/2016, Leo Famulari <leo@famulari.name> wrote:
> > Except where necessary for the new version to work, it's best to do
> > updates in a separate commit from other changes.
> >
> > I can apply the update myself if you say it's okay to do on its own, or
> > feel free to submit a revised patch set.
> 
> Er, no. This whole thing is pretty — what's the eufemism — atomic:
> 
> PackageKit support is a ‘new’ upstream addition. Guix doesn't ship a
> PackageKit expression. Nor would writing one add much value, since its
> sole purpose is to serve as an abstraction layer for other, ‘impure’
> package managers[1].
> 
> I therefore simply disabled it.

I think that lots of software in our distribution has unused features or
portability "goop" that doesn't apply to us, but we don't delete that
code.

> 
> > Does 'src/ui.c' cause problems for us? I'd rather not make changes to
> > upstream code except when necesssary [0], at least not without
> > discussing it with upstream first.
> 
> However, a stale file (src/ui.c) in the tarball still references packagekit:
> 
>   make[1]: Entering directory
> '/tmp/guix-build-simple-scan-3.19.91.drv-0/build/src'
>     CC       simple_scan-ui.o
>   ../../simple-scan-3.19.91/src/ui.c:28:41: fatal error: \
>      packagekit-glib2/packagekit.h: No such file or directory
>    #include "packagekit-glib2/packagekit.h"
> 
> Simply adding ‘make clean’ doesn't work (because that assumes we're
> building in the source directory and Guix doesn't). Removing the
> offending file fixes the build & seemed more clear.

So, it fails to build from source if you don't delete this file?

I still don't understand why we should delete the source file.

After searching online for "packagekit simple scan" I found the Nix
package definition for Simple Scan 3.19.91. They pass to ./configure
'--disable-packagekit'. Would that work?

https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/graphics/simple-scan/default.nix

  parent reply	other threads:[~2016-03-09  0:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08 22:04 [PATCH] gnu: simple-scan: Update to 3.19.91 Tobias Geerinckx-Rice
2016-03-08 23:02 ` Leo Famulari
2016-03-08 23:43   ` Tobias Geerinckx-Rice
2016-03-08 23:50     ` Tobias Geerinckx-Rice
2016-03-09  0:05     ` Leo Famulari [this message]
2016-03-09  0:25       ` Tobias Geerinckx-Rice
2016-03-09  1:39         ` Leo Famulari
2016-03-09  7:49           ` Leo Famulari
2016-03-09 13:28             ` Ludovic Courtès
2016-03-09 20:56               ` Leo Famulari
2016-03-12 20:33                 ` Danny Milosavljevic
2016-03-13 10:34                   ` Danny Milosavljevic
2016-03-13 16:27                     ` Tobias Geerinckx-Rice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160309000506.GD24107@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=tobias.geerinckx.rice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).