From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Include CodingQuarry gene predictor
Date: Tue, 8 Mar 2016 18:39:37 -0500
Message-ID: <20160308233937.GB24107@jasmine>
References: <CAEf4xgeu18CvOoO0cC3rm3q3TxtROEtt56iTr7gDDoG7sKuW9w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47596)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1adREI-0008BK-PN
	for guix-devel@gnu.org; Tue, 08 Mar 2016 18:39:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1adREF-0002b0-K9
	for guix-devel@gnu.org; Tue, 08 Mar 2016 18:39:54 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60279)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1adREF-0002ar-G5
	for guix-devel@gnu.org; Tue, 08 Mar 2016 18:39:51 -0500
Content-Disposition: inline
In-Reply-To: <CAEf4xgeu18CvOoO0cC3rm3q3TxtROEtt56iTr7gDDoG7sKuW9w@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Rob Syme <rob.syme@gmail.com>
Cc: guix-devel@gnu.org

On Tue, Mar 08, 2016 at 05:13:34PM +0800, Rob Syme wrote:

Thank you for the patch!

> * gnu/packages/bioinformatics.scm: Add codingquarry package description

When adding packages, we have a preferred format for the commit message.
It's either the GNU changelog format or a slightly modified version (I'm
not sure). You can see a good example in commit 0e2f2aebed.

[...]

> +         (delete 'check) ;; Don't run the 'make check' step of the
> gnu-build-system

When skippping the tests, we prefer to say why in the comment. It can be
as simple as "no test suite" if that is the case.

[...]

> +    (native-inputs `(("python", python-2)))

If the software only works with Python 2, I prefer to say so in a
comment such as "Only Python 2 is supported." I don't think is official
policy but I find it a useful piece of information to leave for other
readers.

Can you submit a revised patch that addresses these issues?