From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH 3/5] gnu: Split python2-pyicu into python-pyicu and python2-pyicu. Date: Sat, 5 Mar 2016 21:42:59 +0200 Message-ID: <20160305194259.GC30081@debian-netbook> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ALfTUftag+2gvp1h" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:32988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acI6U-0001G1-SC for guix-devel@gnu.org; Sat, 05 Mar 2016 14:43:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acI6R-0006X5-2S for guix-devel@gnu.org; Sat, 05 Mar 2016 14:43:06 -0500 Received: from flashner.co.il ([178.62.234.194]:60024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acI6Q-0006Vv-OC for guix-devel@gnu.org; Sat, 05 Mar 2016 14:43:03 -0500 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org --ALfTUftag+2gvp1h Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 03, 2016 at 05:11:54PM -0500, Leo Famulari wrote: > * gnu/packages/python.scm (python2-pyicu): Split variable into... > (python-pyicu, python2-pyicu): ...both Python variants. > (python-pyicu)[arguments]: Enable tests. > --- If we had the python- variant and were adding the python2- variant then the message would be "add python2 variant," so I'd go with something similar. Currently reading it I thought that there was already the python and python2 variants, and there was a bigger split going on. > gnu/packages/python.scm | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) >=20 > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index f168d15..b168183 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -1133,9 +1133,9 @@ Python 3.3+.") > (package-with-python2 python-simplejson)) > =20 > =20 > -(define-public python2-pyicu > +(define-public python-pyicu > (package > - (name "python2-pyicu") > + (name "python-pyicu") > (version "1.9.2") > (source > (origin > @@ -1148,15 +1148,18 @@ Python 3.3+.") > (build-system python-build-system) > (inputs > `(("icu4c" ,icu4c))) > - (arguments > - `(#:python ,python-2 ; Python 3 works also, but needs special care = for > - ; linking with libpython3.3m Whatever the magic that was needed, does it work? > - #:tests? #f)) ; no check target > (home-page "http://pyicu.osafoundation.org/") > (synopsis "Python extension wrapping the ICU C++ API") > (description > "PyICU is a python extension wrapping the ICU C++ API.") > - (license x11))) > + (license x11) > + (properties `((python2-variant . ,(delay python2-pyicu)))))) > + > +(define-public python2-pyicu > + (package > + (inherit (package-with-python2 > + (strip-python2-variant python-pyicu))) > + (native-inputs `(("python2-setuptools" ,python2-setuptools))))) > =20 > (define-public python2-dogtail > ;; Python 2 only, as it leads to "TabError: inconsistent use of tabs a= nd > --=20 > 2.6.3 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --ALfTUftag+2gvp1h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJW2zbDAAoJEPTB05F+rO6TAO0P/3Ek+mr06cCKtP0V1T5yqGN4 qJSqDFdaib28gJygSRWh7drRomowHum1Iwr00HPqka4nb32wUPJIaKwTzsVNPfLZ lseB6ZorwGIblKIHRD8Mr77ASQn5GJVZsoCkeXF+Ekk363I75WDUDJe379STeADM ECUlymmtAeD80E5aHKTdEg4paqeLwbgVLbdZ5nW/eXzy3haWMk2iI6LXK3AN5nEc 1Y5ANVxIvBvmYTia7aSiGXt1L0D8krcS3HJ4Y1GczeObDwHQR7hCoWf4V5t066fQ Gj1K623noZwDED+bFuHwBV8BOtZCUodZ0wSs2Cne8sRMUmlcVCI29EuKPEXZmAU3 hwh7SgFXnMS+gJJMwGR7xGc5KI8IkgEju2q/PTFkH3JMdo3NipyBO0xxv8CbfzEF 4zczqz9Rt7HJb8hYwnT4nALO8cKmCv5vye2LU6u9CtOvcXIWPwuiYUb5Ov9NGPzn /Y9hAOVaXizsu67XRIVEL4cJH5kFEcaz1+1vr42vrhbvJAKnRSyoPzIVGAQlgZlU OJdTBrcIDEroIU1E6lyLh8MgZ3GN6xuS2XzKZEsujb/iCypPQF8Qu+AIWnAocQwF G9SZUyBeYqGhZuJOQTYmmiLy1Q3mD/OJOF36UYHSMr65mRAbbBu3rFpjXTe0hiBe 3sA3T+juyH7A6Wlni/eS =gyiX -----END PGP SIGNATURE----- --ALfTUftag+2gvp1h--