From: Efraim Flashner <efraim@flashner.co.il>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/5] gnu: Split python2-pyicu into python-pyicu and python2-pyicu.
Date: Sat, 5 Mar 2016 21:42:59 +0200 [thread overview]
Message-ID: <20160305194259.GC30081@debian-netbook> (raw)
In-Reply-To: <a419c60a3ad4905c80dddb91bf87a183a9255c67.1457042922.git.leo@famulari.name>
[-- Attachment #1: Type: text/plain, Size: 2380 bytes --]
On Thu, Mar 03, 2016 at 05:11:54PM -0500, Leo Famulari wrote:
> * gnu/packages/python.scm (python2-pyicu): Split variable into...
> (python-pyicu, python2-pyicu): ...both Python variants.
> (python-pyicu)[arguments]: Enable tests.
> ---
If we had the python- variant and were adding the python2- variant then
the message would be "add python2 variant," so I'd go with something
similar. Currently reading it I thought that there was already the
python and python2 variants, and there was a bigger split going on.
> gnu/packages/python.scm | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index f168d15..b168183 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -1133,9 +1133,9 @@ Python 3.3+.")
> (package-with-python2 python-simplejson))
>
>
> -(define-public python2-pyicu
> +(define-public python-pyicu
> (package
> - (name "python2-pyicu")
> + (name "python-pyicu")
> (version "1.9.2")
> (source
> (origin
> @@ -1148,15 +1148,18 @@ Python 3.3+.")
> (build-system python-build-system)
> (inputs
> `(("icu4c" ,icu4c)))
> - (arguments
> - `(#:python ,python-2 ; Python 3 works also, but needs special care for
> - ; linking with libpython3.3m
Whatever the magic that was needed, does it work?
> - #:tests? #f)) ; no check target
> (home-page "http://pyicu.osafoundation.org/")
> (synopsis "Python extension wrapping the ICU C++ API")
> (description
> "PyICU is a python extension wrapping the ICU C++ API.")
> - (license x11)))
> + (license x11)
> + (properties `((python2-variant . ,(delay python2-pyicu))))))
> +
> +(define-public python2-pyicu
> + (package
> + (inherit (package-with-python2
> + (strip-python2-variant python-pyicu)))
> + (native-inputs `(("python2-setuptools" ,python2-setuptools)))))
>
> (define-public python2-dogtail
> ;; Python 2 only, as it leads to "TabError: inconsistent use of tabs and
> --
> 2.6.3
>
>
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-05 19:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 22:11 [PATCH 0/5] Add Khard and dependencies Leo Famulari
2016-03-03 22:11 ` [PATCH 1/5] gnu: Add python2-atomicwrites Leo Famulari
2016-03-13 22:26 ` Ludovic Courtès
2016-03-03 22:11 ` [PATCH 2/5] gnu: python2-pyicu: Update to 1.9.2 Leo Famulari
2016-03-13 22:27 ` Ludovic Courtès
2016-03-03 22:11 ` [PATCH 3/5] gnu: Split python2-pyicu into python-pyicu and python2-pyicu Leo Famulari
2016-03-05 19:42 ` Efraim Flashner [this message]
2016-03-05 22:32 ` Leo Famulari
2016-03-06 0:40 ` Leo Famulari
2016-03-06 12:58 ` Andreas Enge
2016-03-06 18:49 ` Leo Famulari
2016-03-13 22:31 ` Leo Famulari
2016-03-13 22:28 ` Ludovic Courtès
2016-03-13 22:32 ` Leo Famulari
2016-03-03 22:11 ` [PATCH 4/5] gnu: Add python-vobject Leo Famulari
2016-03-13 22:28 ` Ludovic Courtès
2016-03-03 22:11 ` [PATCH 5/5] gnu: Add khard Leo Famulari
2016-03-03 22:14 ` Leo Famulari
2016-03-05 19:42 ` Efraim Flashner
2016-03-05 22:10 ` Leo Famulari
2016-03-13 22:32 ` Ludovic Courtès
2016-03-13 22:45 ` Leo Famulari
2016-03-05 19:42 ` [PATCH 0/5] Add Khard and dependencies Efraim Flashner
2016-03-05 22:11 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305194259.GC30081@debian-netbook \
--to=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).