From: Leo Famulari <leo@famulari.name>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 12/13] gnu: Add python-rarfile.
Date: Fri, 4 Mar 2016 16:29:40 -0500 [thread overview]
Message-ID: <20160304212940.GA463@jasmine> (raw)
In-Reply-To: <idjd1raxvmk.fsf@bimsb-sys02.mdc-berlin.net>
On Fri, Mar 04, 2016 at 01:42:11PM +0100, Ricardo Wurmus wrote:
>
> Leo Famulari <leo@famulari.name> writes:
>
> > * gnu/packages/python.scm (python-rarfile, python2-rarfile): New
> > variables.
> > * gnu/packages/patches/python-rarfile-fix-tests.patch: New file.
> > * gnu-system.am (dist_patch_DATA): Add it.
> > ---
>
> [...]
>
> > + (propagated-inputs
> > + `(("libarchive" ,libarchive)))
> > + (home-page "https://github.com/markokr/rarfile")
> > + (synopsis "RAR archive reader for Python")
> > + (description "This is Python module for RAR archive reading. The interface
> > +is made as zipfile like as possible.")
> > + (license isc)))
>
> Does this actually work? I assumed that our “libarchive” package has no
> support for RAR archives.
I don't know. The libarchive documentation in
'share/man/man5/libarchive-formats.5.gz' does list RAR as a supported
format.
I added python-rarfile since the beets build process fails when it can't
find it. I'd be surprised if it's really necessary though.
In the beets source tarball, the string "rarfile" appears as a test
requirement, and in 'beets/importer.py'. The importer is what a user
invokes to add music to the beets database. Rarfile is not imported as a
module by importer.py, so its absence shouldn't have any effect until a
user actually tries to exercise the feature, if my (weak) understanding
of Python is correct.
I built a beets variant without rarfile, and tested the import
functionality. It works as expected on uncompressed directories. It
fails on archives, but it does that even without this change.
So, what should I do? Patch "rarfile" out of setup.py or package
python-rarfile?
next prev parent reply other threads:[~2016-03-04 21:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 1:26 [PATCH 00/13] Add beets and its dependencies Leo Famulari
2016-03-04 1:26 ` [PATCH 01/13] gnu: Add python-mutagen Leo Famulari
2016-03-04 1:26 ` [PATCH 02/13] gnu: Add python-munkres Leo Famulari
2016-03-04 1:26 ` [PATCH 03/13] gnu: Add python-musicbrainzngs Leo Famulari
2016-03-04 1:26 ` [PATCH 04/13] gnu: Add python-flask Leo Famulari
2016-03-04 1:26 ` [PATCH 05/13] gnu: Add python-pyechonest Leo Famulari
2016-03-04 1:26 ` [PATCH 06/13] gnu: Add python-pylast Leo Famulari
2016-03-04 1:26 ` [PATCH 07/13] gnu: Add python-responses Leo Famulari
2016-03-04 1:26 ` [PATCH 08/13] gnu: Add python2-pathlib Leo Famulari
2016-03-04 1:26 ` [PATCH 09/13] gnu: Add python-mpd2 Leo Famulari
2016-03-04 1:26 ` [PATCH 10/13] gnu: Add python-jellyfish Leo Famulari
2016-03-04 1:26 ` [PATCH 11/13] gnu: Add python2-unicodecsv Leo Famulari
2016-03-04 1:26 ` [PATCH 12/13] gnu: Add python-rarfile Leo Famulari
2016-03-04 12:42 ` Ricardo Wurmus
2016-03-04 21:29 ` Leo Famulari [this message]
2016-03-13 22:00 ` Leo Famulari
2016-03-17 21:31 ` Ricardo Wurmus
2016-03-17 21:59 ` Leo Famulari
2016-03-18 6:44 ` Efraim Flashner
2016-03-18 16:24 ` Leo Famulari
2016-03-04 1:26 ` [PATCH 13/13] gnu: Add beets Leo Famulari
2016-03-18 18:29 ` Leo Famulari
2016-03-18 20:42 ` Ludovic Courtès
2016-03-25 16:04 ` Mark H Weaver
2016-03-25 17:27 ` Leo Famulari
2016-03-25 23:37 ` Alex Griffin
2016-03-26 0:30 ` Leo Famulari
2016-03-26 0:40 ` Leo Famulari
2016-03-26 11:41 ` Ludovic Courtès
2016-03-26 14:58 ` Alex Griffin
2016-03-27 21:36 ` Leo Famulari
2016-03-27 22:25 ` Leo Famulari
2016-03-28 16:25 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304212940.GA463@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).