Re: [PATCH] gnu: lynx: Support HTTPS (SSL) connections

[Leo Famulari <leo@famulari.name>]

On Fri, Mar 04, 2016 at 03:37:46AM +0100, tobias.geerinckx.rice@gmail.com wrote:
> From: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
> 
> * gnu/packages/lynx.scm (lynx)[inputs]: Add 'openssl'.
> [arguments]: Convert to list; add configure flag for SSL support.

Wow, thanks for this patch!

Can you say if you learned anything else... "interesting" about lynx and
https support?

For example, a couple months ago I was reading our bug reports and saw
an old one about https support in w3m (another console browser). I dug a
little deeper and realized that https support was completely broken by
default. You can see the result in commit 62339e2d493bf87.

So, do you know if lynx is still supporting broken ciphers and
protocols, or if there are other problems of that nature?

Also, what is role of gnutls once this patch is applied? Does lynx need
to refer to both gnutls and openssl?

> ---
>  gnu/packages/lynx.scm | 30 +++++++++++++++++-------------
>  1 file changed, 17 insertions(+), 13 deletions(-)
> 
> diff --git a/gnu/packages/lynx.scm b/gnu/packages/lynx.scm
> index 3182b3e..7e1ef1d 100644
> --- a/gnu/packages/lynx.scm
> +++ b/gnu/packages/lynx.scm
> @@ -48,24 +48,28 @@
>                ("libidn" ,libidn)
>                ("gnutls" ,gnutls)
>                ("libgcrypt" ,libgcrypt)
> +              ("openssl" ,openssl)
>                ("unzip" ,unzip)
>                ("zlib" ,zlib)
>                ("gzip" ,gzip)
>                ("bzip2" ,bzip2)))
>      (arguments
> -     `(#:configure-flags '("--with-pkg-config"
> -                           "--with-screen=ncurses"
> -                           "--with-zlib"
> -                           "--with-bzlib"
> -                           "--with-gnutls"
> -                           ;; "--with-socks5"    ; XXX TODO
> -                           "--enable-widec"
> -                           "--enable-ascii-ctypes"
> -                           "--enable-local-docs"
> -                           "--enable-htmlized-cfg"
> -                           "--enable-gzip-help"
> -                           "--enable-nls"
> -                           "--enable-ipv6")
> +     `(#:configure-flags
> +       (list "--with-pkg-config"
> +             "--with-screen=ncurses"
> +             "--with-zlib"
> +             "--with-bzlib"
> +             "--with-gnutls"
> +             (string-append "--with-ssl="
> +                            (assoc-ref %build-inputs "openssl"))
> +             ;; "--with-socks5"    ; XXX TODO
> +             "--enable-widec"
> +             "--enable-ascii-ctypes"
> +             "--enable-local-docs"
> +             "--enable-htmlized-cfg"
> +             "--enable-gzip-help"
> +             "--enable-nls"
> +             "--enable-ipv6")
>         #:tests? #f  ; no check target
>         #:phases (alist-replace
>                   'install
> -- 
> 2.6.3
> 
>