unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/1] gnu: perl: Replace with patched version [fixes CVE-2016-2381].
Date: Thu, 3 Mar 2016 00:52:27 -0500	[thread overview]
Message-ID: <20160303055227.GA26189@jasmine> (raw)
In-Reply-To: <20160303040613.GA24614@jasmine>

On Wed, Mar 02, 2016 at 11:06:13PM -0500, Leo Famulari wrote:
> On Wed, Mar 02, 2016 at 10:52:58PM +0100, Ludovic Courtès wrote:
> > Leo Famulari <leo@famulari.name> skribis:
> > 
> > > * gnu/packages/patches/perl-CVE-2016-2381.patch: New file.
> > > * gnu-system.am (dist_patch_DATA): Add it.
> > > * gnu/packages/perl.scm (perl)[replacement]: New field.
> > > (perl-5.22.1-2): New variable.
> > 
> > Should be ‘perl-fixed’.
> 
> Done. I also altered the context of the patch to reflect that its
> source is actually upstream Perl, although Debian did cherry-pick it.
> 
> > 
> > > * gnu/packages/commencement.scm (perl-boot0)[replacement]: New field.
> > 
> > Otherwise LGTM, as long as you confirm that nothing goes really wrong
> > once it’s applied.  :-)
> 
> Here are some things I tried:
> 
> 1) Built and booted a VM with `guix system vm`. I don't know if perl (as
> opposed to perl-boot0) is used in this process, but it did work.
> 
> 2) Built and installed git on top of it, and then rolled back the commit
> and used `git add -i` to recreate it, and then `git send-email` to
> submit it. Both of those tools are Perl scripts.

By "on top of it" I mean on top of this patch, not on the VM.

> 
> https://git.kernel.org/cgit/git/git.git/tree/git-add--interactive.perl
> https://git.kernel.org/cgit/git/git.git/tree/git-send-email.perl

  reply	other threads:[~2016-03-03  5:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 19:48 [PATCH 0/1] Perl: Fix CVE-2016-2381 Leo Famulari
2016-03-02 19:48 ` [PATCH 1/1] gnu: perl: Replace with patched version [fixes CVE-2016-2381] Leo Famulari
2016-03-02 21:52   ` Ludovic Courtès
2016-03-03  4:06     ` Leo Famulari
2016-03-03  5:52       ` Leo Famulari [this message]
2016-03-03 16:33       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160303055227.GA26189@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).