From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH 1/2] gnu: Add python-backports-abc. Date: Sun, 28 Feb 2016 09:37:59 +0100 Message-ID: <20160228083759.GA16526@solar> References: <1456477883-21423-1-git-send-email-efraim@flashner.co.il> <1456477883-21423-2-git-send-email-efraim@flashner.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZwrf-0002dP-5m for guix-devel@gnu.org; Sun, 28 Feb 2016 03:38:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZwrc-0004Y9-0R for guix-devel@gnu.org; Sun, 28 Feb 2016 03:38:07 -0500 Received: from mailrelay1.public.one.com ([91.198.169.124]:13628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZwrb-0004Y3-LY for guix-devel@gnu.org; Sun, 28 Feb 2016 03:38:03 -0500 Content-Disposition: inline In-Reply-To: <1456477883-21423-2-git-send-email-efraim@flashner.co.il> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Efraim Flashner Cc: guix-devel@gnu.org On Fri, Feb 26, 2016 at 11:11:22AM +0200, Efraim Flashner wrote: > + (description > + "A backport of recent additions to the 'collections.abc' module.") This should be a full sentence; right now it is missing a verb, at least it should be "foo is/constitutes/provides a backport". "recent additions" is a bit vague; maybe add that it backports features of Python 3.5? Otherwise it looks good; and then there is nothing to say about the python-tornado update. Andreas