On Tue, 23 Feb 2016 16:29:44 -0600
Eric Bavier <ericbavier@openmailbox.org> wrote:

> On Fri, 19 Feb 2016 20:54:22 +0100
> Danny Milosavljevic <dannym@scratchpost.org> wrote:
> 
> > Hi,
> > 
> > On Fri, 19 Feb 2016 08:20:21 -0600
> > Eric Bavier <ericbavier@openmailbox.org> wrote:
> >   
> > > This new package should rather go in gnu/packages/wm.scm.    
> > 
> > I'd like to do that but it doesn't work. If I put the package name "fluxbox" into /etc/config.scm and import "wm" there, it will complain that it doesn't know "fluxbox". Works fine when I put it in gnu/packages/fluxbox.scm and import "fluxbox", though.
> >   
> > > This file download is trivial.  I think we should do something like
> > > what's done for xmonad currently.  Namely, generating our own .desktop
> > > file.  Please see that package.    
> > 
> > I'll check that out after I got it to work inside "wm".  
> 
> Thanks.
> 
> > > Could you send an updated patch?    
> > 
> > I'd like to but it really doesn't work in wm right now.  
> 
> See below.
> 
> > 
> > diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> > index 1765c3a..a1df857 100644
> > --- a/gnu/packages/wm.scm
> > +++ b/gnu/packages/wm.scm
> > @@ -21,7 +21,7 @@
> >  ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> >  
> >  (define-module (gnu packages wm)
> > -  #:use-module (guix licenses)
> > +  #:use-module ((guix licenses) #:prefix license:)  
> 
> Fluxbox might have been reported missing since there is an instance of
> "x11-style" that didn't get a license: prefix, so compilation would
> fail.
> 
> [...]
> > +    (inputs `(("imlib2" ,imlib2)
> > +              ("libx11" ,libx11)
> > +              ;("libxml2" ,libxml2)
> > +              ;("librsvg" ,librsvg)
> > +              ;("libsm" ,libsm)
> > +              ;("libxcursor" ,libxcursor)
> > +              ("libxinerama" ,libxinerama)
> > +              ;("libxml2" ,libxml2)
> > +              ("libxrandr" ,libxrandr)
> > +              ("libxext" ,libxext)
> > +              ("libxrender" ,libxrender)
> > +              ("libxft" ,libxft)
> > +              ("freetype" ,freetype)  
> 
> This will require a "#:use-module (gnu packages fontutils)"
> 
> > +              ("fribidi" ,fribidi)
> > +              ("libxpm"  ,libxpm)))
> > +    (synopsis "Window manager with tabs")
> > +    (description "Fluxbox is a window manager. 
> > +The 'box' visual style is well known for its minimalistic appearance.")
> > +    (home-page "http://fluxbox.org/")
> > +    (license license:expat)))
> > +  
> 
> With those changes, you should be able to build and load up fluxbox
> from gnu/packages/wm.scm (I was able to with `guix system vm').

I went ahead and made the above changes in the attached patch.  Please
let me know if the copyright line and git author are appropriate.

Thanks,
`~Eric