unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 0/1] Remove an unused patch?
@ 2016-02-20  4:22 Leo Famulari
  2016-02-20  4:22 ` [PATCH 1/1] gnu: cpio: Remove unused patch Leo Famulari
  2016-03-05 16:14 ` [PATCH 0/1] Remove an unused patch? Andreas Enge
  0 siblings, 2 replies; 8+ messages in thread
From: Leo Famulari @ 2016-02-20  4:22 UTC (permalink / raw)
  To: guix-devel

The patch file 'cpio-gets-undeclared.patch' was "de-applied" to the cpio
sources when we upgraded cpio to 2.12 (92d0fcb6dc5). But, it was never
deleted or removed from gnu-system.am.

So, should we delete it or re-apply it? I guess the answer depends on
whether or not cpio still uses gets().

I searched for use of gets() in the cpio-2.12 source tree like this:
$ grep -rI 'gets ('
$ grep -rI 'gets('

All the results were uses of fgets(). Is that reasonable method of
searching or should I continue with some other technique?

Leo Famulari (1):
  gnu: cpio: Remove unused patch.

 gnu-system.am                                   |  1 -
 gnu/packages/patches/cpio-gets-undeclared.patch | 45 -------------------------
 2 files changed, 46 deletions(-)
 delete mode 100644 gnu/packages/patches/cpio-gets-undeclared.patch

-- 
2.7.1

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2016-03-06 12:49 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-20  4:22 [PATCH 0/1] Remove an unused patch? Leo Famulari
2016-02-20  4:22 ` [PATCH 1/1] gnu: cpio: Remove unused patch Leo Famulari
2016-02-26  0:20   ` Mark H Weaver
2016-02-26  1:32     ` Leo Famulari
2016-03-05 16:14 ` [PATCH 0/1] Remove an unused patch? Andreas Enge
2016-03-05 21:57   ` Ludovic Courtès
2016-03-05 22:08     ` Leo Famulari
2016-03-06 12:49       ` Andreas Enge

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).