From: Leo Famulari <leo@famulari.name>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH v3] gnu: Add python-psycopg2, python2-psycopg2
Date: Thu, 25 Feb 2016 18:13:03 -0500 [thread overview]
Message-ID: <20160225231303.GA32264@jasmine> (raw)
In-Reply-To: <87povke7f3.fsf@dustycloud.org>
On Thu, Feb 25, 2016 at 02:45:04PM -0800, Christopher Allan Webber wrote:
> Danny Milosavljevic writes:
>
> > Hi,
> >
> > first, thanks for the review and test and commit.
> >
> > On Thu, 25 Feb 2016 09:53:17 -0800
> > Christopher Allan Webber <cwebber@dustycloud.org> wrote:
> >
> >> This looks ready to go, though it still lacks a changelog style commit
> >> message,
> >
> > I committed it locally, with a commit message... *shrugs*.
> > I think git format-patch put the message into the subject.
> > Should I manually write a changelog-style blurb, too?
> >
> >>and it isn't formatted with git format-patch.
> >
> > Huh? After the local commit I called git format-patch to format it and the mail with the patch was created from its output.
> >
> > btw: Now git pull merges every time I pull... hmmmmm...
>
> If you committed your own patch to master, that's not the same as what
> will be applied upstream. I failed to push earlier today (someone else
> had), but it's actually up now. If you ensure that your commit is
> actually upstream (check the logs) and you're on master you can do:
>
> git reset --hard origin/master
This will discard any other work you've done on the master branch.
I would do `git diff HEAD..origin/master` to see what the difference is.
next prev parent reply other threads:[~2016-02-25 23:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 11:01 [PATCH] gnu: Add python-psycopg2, python2-psycopg2 Danny Milosavljevic
2016-02-19 21:22 ` Leo Famulari
2016-02-22 0:39 ` Danny Milosavljevic
2016-02-22 2:38 ` Christopher Allan Webber
2016-02-24 22:39 ` [PATCH v2] " Danny Milosavljevic
2016-02-25 0:05 ` Christopher Allan Webber
2016-02-25 0:52 ` [PATCH v3] " Danny Milosavljevic
2016-02-25 17:53 ` Christopher Allan Webber
2016-02-25 19:30 ` Leo Famulari
2016-02-25 21:28 ` Christopher Allan Webber
2016-02-25 21:35 ` Leo Famulari
2016-02-25 22:22 ` Danny Milosavljevic
2016-02-25 22:45 ` Christopher Allan Webber
2016-02-25 23:13 ` Leo Famulari [this message]
2016-02-25 23:52 ` Christopher Allan Webber
2016-02-22 2:39 ` [PATCH] " Christopher Allan Webber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225231303.GA32264@jasmine \
--to=leo@famulari.name \
--cc=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).