From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/1] gnu: diffoscope: Update to 49.
Date: Thu, 25 Feb 2016 17:08:31 -0500
Message-ID: <20160225220831.GA28618@jasmine>
References: <cover.1456362314.git.leo@famulari.name>
	<bca1f32a20425e5a58dc16d2893d56f63c6bfb0f.1456362314.git.leo@famulari.name>
	<idj8u292h9g.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59095)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aZ45Q-000501-F6
	for guix-devel@gnu.org; Thu, 25 Feb 2016 17:08:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aZ45M-0006Jl-Rs
	for guix-devel@gnu.org; Thu, 25 Feb 2016 17:08:40 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:55593)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aZ45M-0006JT-LW
	for guix-devel@gnu.org; Thu, 25 Feb 2016 17:08:36 -0500
Content-Disposition: inline
In-Reply-To: <idj8u292h9g.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org

On Thu, Feb 25, 2016 at 11:53:15AM +0100, Ricardo Wurmus wrote:
> 
> Leo Famulari <leo@famulari.name> writes:
> 
> > * gnu/packages/package-management.scm (diffoscope): Update to 49.
> > [source]: Use pypi-uri.
> > [arguments]: Use python-3. Enable tests. Add 'dependency-on-python-magic' phase
> > and remove 'dependency-on-rpm' phase.
> > ---
> [...]
> >      (inputs `(("rpm" ,rpm)                        ;for rpm-python
> > -              ("python-file" ,python2-file)
> > -              ("python-debian" ,python2-debian)
> > -              ("python-libarchive-c" ,python2-libarchive-c)
> > -              ("python-tlsh" ,python2-tlsh)
> > +              ("python-file" ,python-file)
> > +              ("python-debian" ,python-debian)
> > +              ("python-libarchive-c" ,python-libarchive-c)
> > +              ("python-tlsh" ,python-tlsh)
> >  
> >                ;; Below are modules used for tests.
> > -              ("python-pytest" ,python2-pytest)
> > -              ("python-chardet" ,python2-chardet)))
> > -    (native-inputs `(("python-setuptools" ,python2-setuptools)))
> > +              ("python-pytest" ,python-pytest)
> > +              ("python-chardet" ,python-chardet)))
> >      (home-page "http://diffoscope.org/")
> >      (synopsis "Compare files, archives, and directories in depth")
> >      (description
> 
> 
> Since you’re changing “inputs” and “native-inputs” you should mention
> these changes in the commit summary.

Done, and pushed as 7dd21101a3.

> Otherwise looks okay to me.

Thanks for the review!

> 
> ~~ Ricardo