unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/1] gnu: diffoscope: Update to 49.
Date: Thu, 25 Feb 2016 17:08:31 -0500	[thread overview]
Message-ID: <20160225220831.GA28618@jasmine> (raw)
In-Reply-To: <idj8u292h9g.fsf@bimsb-sys02.mdc-berlin.net>

On Thu, Feb 25, 2016 at 11:53:15AM +0100, Ricardo Wurmus wrote:
> 
> Leo Famulari <leo@famulari.name> writes:
> 
> > * gnu/packages/package-management.scm (diffoscope): Update to 49.
> > [source]: Use pypi-uri.
> > [arguments]: Use python-3. Enable tests. Add 'dependency-on-python-magic' phase
> > and remove 'dependency-on-rpm' phase.
> > ---
> [...]
> >      (inputs `(("rpm" ,rpm)                        ;for rpm-python
> > -              ("python-file" ,python2-file)
> > -              ("python-debian" ,python2-debian)
> > -              ("python-libarchive-c" ,python2-libarchive-c)
> > -              ("python-tlsh" ,python2-tlsh)
> > +              ("python-file" ,python-file)
> > +              ("python-debian" ,python-debian)
> > +              ("python-libarchive-c" ,python-libarchive-c)
> > +              ("python-tlsh" ,python-tlsh)
> >  
> >                ;; Below are modules used for tests.
> > -              ("python-pytest" ,python2-pytest)
> > -              ("python-chardet" ,python2-chardet)))
> > -    (native-inputs `(("python-setuptools" ,python2-setuptools)))
> > +              ("python-pytest" ,python-pytest)
> > +              ("python-chardet" ,python-chardet)))
> >      (home-page "http://diffoscope.org/")
> >      (synopsis "Compare files, archives, and directories in depth")
> >      (description
> 
> 
> Since you’re changing “inputs” and “native-inputs” you should mention
> these changes in the commit summary.

Done, and pushed as 7dd21101a3.

> Otherwise looks okay to me.

Thanks for the review!

> 
> ~~ Ricardo

      reply	other threads:[~2016-02-25 22:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25  1:06 [PATCH 0/1] diffoscope update Leo Famulari
2016-02-25  1:06 ` [PATCH 1/1] gnu: diffoscope: Update to 49 Leo Famulari
2016-02-25 10:53   ` Ricardo Wurmus
2016-02-25 22:08     ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160225220831.GA28618@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).