From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH v3] gnu: Add python-psycopg2, python2-psycopg2 Date: Thu, 25 Feb 2016 16:35:10 -0500 Message-ID: <20160225213510.GB20345@jasmine> References: <20160219120106.62631a44@scratchpost.org> <20160219212258.GA4418@jasmine> <20160222013949.186f25bc@scratchpost.org> <87egc54gg4.fsf@dustycloud.org> <20160224233918.3d70dd72@scratchpost.org> <87vb5dr6wx.fsf@dustycloud.org> <20160225015212.2dc928c3@scratchpost.org> <878u28fzik.fsf@dustycloud.org> <20160225193000.GB18435@jasmine> <87r3g0eay1.fsf@dustycloud.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ3Z6-0003Et-P1 for guix-devel@gnu.org; Thu, 25 Feb 2016 16:35:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZ3Z3-0003sH-U5 for guix-devel@gnu.org; Thu, 25 Feb 2016 16:35:16 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:41013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ3Z3-0003sC-QX for guix-devel@gnu.org; Thu, 25 Feb 2016 16:35:13 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id A2FFD21383 for ; Thu, 25 Feb 2016 16:35:13 -0500 (EST) Content-Disposition: inline In-Reply-To: <87r3g0eay1.fsf@dustycloud.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Christopher Allan Webber Cc: guix-devel On Thu, Feb 25, 2016 at 01:28:54PM -0800, Christopher Allan Webber wrote: > Leo Famulari writes: > > > On Thu, Feb 25, 2016 at 09:53:17AM -0800, Christopher Allan Webber wrote: > >> This looks ready to go, though it still lacks a changelog style commit > >> message, and it isn't formatted with git format-patch. > >> > >> I could commit it myself with that, but I don't know if that would be > >> acceptable? (And should I commit it under my name, or set the author > >> name to Danny? I would certainly want to attribute to Danny.) > > > > It's actually possible to put anything you want in the '--author' field > > when committing. There is also '--sign-off', which you can use to > > indicate your approval of the author's patch. These options also exist > > in some other git tools, notably `git am`. > > Ok, good call. I probably should have done --sign-off, which I forgot > to, but I did commit it under Danny and pushed it. It's useful but not essential, especially since you can make it say anything you want. The only way to *really* know who wrote what is to sign everything cryptographically.