From: Leo Famulari <leo@famulari.name>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH v3] gnu: Add python-psycopg2, python2-psycopg2
Date: Thu, 25 Feb 2016 16:35:10 -0500 [thread overview]
Message-ID: <20160225213510.GB20345@jasmine> (raw)
In-Reply-To: <87r3g0eay1.fsf@dustycloud.org>
On Thu, Feb 25, 2016 at 01:28:54PM -0800, Christopher Allan Webber wrote:
> Leo Famulari writes:
>
> > On Thu, Feb 25, 2016 at 09:53:17AM -0800, Christopher Allan Webber wrote:
> >> This looks ready to go, though it still lacks a changelog style commit
> >> message, and it isn't formatted with git format-patch.
> >>
> >> I could commit it myself with that, but I don't know if that would be
> >> acceptable? (And should I commit it under my name, or set the author
> >> name to Danny? I would certainly want to attribute to Danny.)
> >
> > It's actually possible to put anything you want in the '--author' field
> > when committing. There is also '--sign-off', which you can use to
> > indicate your approval of the author's patch. These options also exist
> > in some other git tools, notably `git am`.
>
> Ok, good call. I probably should have done --sign-off, which I forgot
> to, but I did commit it under Danny and pushed it.
It's useful but not essential, especially since you can make it say
anything you want. The only way to *really* know who wrote what is to
sign everything cryptographically.
next prev parent reply other threads:[~2016-02-25 21:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 11:01 [PATCH] gnu: Add python-psycopg2, python2-psycopg2 Danny Milosavljevic
2016-02-19 21:22 ` Leo Famulari
2016-02-22 0:39 ` Danny Milosavljevic
2016-02-22 2:38 ` Christopher Allan Webber
2016-02-24 22:39 ` [PATCH v2] " Danny Milosavljevic
2016-02-25 0:05 ` Christopher Allan Webber
2016-02-25 0:52 ` [PATCH v3] " Danny Milosavljevic
2016-02-25 17:53 ` Christopher Allan Webber
2016-02-25 19:30 ` Leo Famulari
2016-02-25 21:28 ` Christopher Allan Webber
2016-02-25 21:35 ` Leo Famulari [this message]
2016-02-25 22:22 ` Danny Milosavljevic
2016-02-25 22:45 ` Christopher Allan Webber
2016-02-25 23:13 ` Leo Famulari
2016-02-25 23:52 ` Christopher Allan Webber
2016-02-22 2:39 ` [PATCH] " Christopher Allan Webber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225213510.GB20345@jasmine \
--to=leo@famulari.name \
--cc=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).